Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TXXX support in mid3v2 #62

Closed
lazka opened this issue Jul 4, 2014 · 10 comments
Closed

TXXX support in mid3v2 #62

lazka opened this issue Jul 4, 2014 · 10 comments
Labels

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 4, 2014

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


From tim.goo...@phipps-hutton.freeserve.co.uk on April 27, 2010 09:59:20

Would be very useful to me.

Original issue: http://code.google.com/p/mutagen/issues/detail?id=62


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From g...@heimskringla.com on September 18, 2010 07:19:56

Here's a patch for enabling editing of TXXX frames in mid3v2.

More in the discussion pages. http://groups.google.com/group/quod-libet-development/browse_thread/thread/32d26fc8fc44b583 Karl

Attachment: changes.patch

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From g...@heimskringla.com on September 21, 2010 02:46:11

I'm not sure this patch works with every version of mid3v2, so I will attach here the version I use, with comments. 

I know, I know, you're not supposed to submit entire files, that are not patch files, but this is just for making it easier to examine.

Karl

Attachment: mid3v2-TXXX-fix

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From tim.goo...@phipps-hutton.freeserve.co.uk on September 22, 2010 03:48:42

Are you sure about TXXX support in mid3v2_1.3. I've just run svn update, purged my system of other mutagens and run this:

./mid3v2 --TXXX "bingle:bongle" test.mp3

and got this:

eyeD3 test.mp3

test.mp3        [ 5.63 MB ]
-------------------------------------------------------------------------------
Time: 03:06     MPEG1, Layer III        [ ~253 kb/s @ 44100 Hz - Joint stereo ]
-------------------------------------------------------------------------------
ID3 v2.4:
title:          artist:
album:          year: None
track:

UserTextFrame: [Description: None]
bingle:bongle


Note the Description is None instead of bingle.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From tim.goo...@phipps-hutton.freeserve.co.uk on September 21, 2010 05:28:36

Thanks, mid3v2-TXXX-fix works nicely but it reports itself as version 1.1. The version in SVN is 1.3 and is quite a bit different which is why the patch doesn't work.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From g...@heimskringla.com on September 22, 2010 12:27:07

Syntax for adding user-defined text data using an updated mid3v2 should be: 

mid3v2 -x  "DESCRIPTION:TEXT"
mid3v2 --usertext  "DESCRIPTION:TEXT"
mid3v2 --TXXX  "DESCRIPTION:TEXT"
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From g...@heimskringla.com on September 22, 2010 11:39:36

I'm sorry, I was wrong. Maybe out of laziness and impatience. It seems I didn't clean out all the old files properly, which gave erroneous results.

TXXX is NOT supported yet. The fix is easy, so I beg the administrators to include this as soon as possible. It is necessary as there is no other command line utility that can handle TXXX writing properly. eyeD3 can write TXXX tags, but corrupts other tags. And eyeD3 is not maintained anymore.

Meanwhile, you can do the following:

If you have mid3v2 1.1 then use the above mid3v2-v1.1+mut1.15.patch to patch the existing /usr/bin/mid3v2 (or wherever it is. Use "which mid3v2").

Or you can use the above mid3v2-TXXX-fix to replace the existing mid3v2. Or use the new file locally, of course.

On the other hand, if you have mid3v2 1.3 (the SVN version) then use either the new patch-file () below or the new replacement file () in a similar way.

Hope I got it right *this* time. Please test, please get back.

Karl

Attachment: mid3v2_1.3 mid3v2_1.3_changes.patch

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From tim.goo...@phipps-hutton.freeserve.co.uk on September 24, 2010 08:32:46

Here's a patch that just extends txxx. Note the 'elif frame == COMM' which fixes the hash error; and the 'split(":", 1)' which allows colons in the rest of the text.

Attachment: txxx.patch

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From phipps.s...@gmail.com on September 28, 2010 02:15:04

Fixed the man page and also simplified the TXXX code.

Attachment: txxx.patch

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From g...@heimskringla.com on September 24, 2010 12:12:11

Great!

I tested it and mid3v2 is working as expected. It's also an improvement to the earlier patch. 

In this case the only syntax would be:

mid3v2 --TXXX "DESCRIPTION:TEXT"

which is enough and perfectly alright.

The man file part has a slight formatting error, though. 

-TXXX "replaygain_track_gain:-9.35 dB" 

should be

\-\-TXXX "replaygain_track_gain:-9.35 dB"

(Surrounded by \fB  \fR for bold text would be even better)
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From joe.wreschnig@gmail.com on October 30, 2010 07:57:16

r97 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.