Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading id3 tagged files with a large padding is slow #65

Closed
lazka opened this issue Jul 4, 2014 · 1 comment
Closed

Loading id3 tagged files with a large padding is slow #65

lazka opened this issue Jul 4, 2014 · 1 comment
Labels

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 4, 2014

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


From reiter.christoph@gmail.com on May 25, 2010 23:27:41

Some of my albums have songs with a large padding (~55640 frames each,
probably itunes).
Loading one song takes 0.6s.

The problem is that ID3.__determine_bpi checks all frames.

The following patch stops reading if it reaches a padding and uses the size
of the left data % 10 to calculate the offset.

Load time with patch: 0.05s

Attachment: bpi_padding.patch

Original issue: http://code.google.com/p/mutagen/issues/detail?id=65


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From joe.wreschnig@gmail.com on July 13, 2010 08:58:22

This issue was closed by revision r88 .

Status: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.