Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mid3iconv: Throws error and halts when destination is a directory #79

Closed
lazka opened this issue Jul 4, 2014 · 1 comment
Closed

mid3iconv: Throws error and halts when destination is a directory #79

lazka opened this issue Jul 4, 2014 · 1 comment
Labels
bug

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 4, 2014

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


From si...@sewell.ch on December 30, 2010 06:17:53

I'm submitting this patch to resolve https://bugzilla.redhat.com/show_bug.cgi?id=641591 Reproduce:

svn co -r 98 http://mutagen.googlecode.com/svn/trunk/ mutagen
cd mutagen/tools
mkdir test
./mid3iconv test

Traceback (most recent call last):
  File "./mid3iconv", line 139, in <module>
    main(sys.argv)
  File "./mid3iconv", line 129, in main
    update(options, args)
  File "./mid3iconv", line 52, in update
    if has_id3v1(filename) and not noupdate and force_v1:
  File "./mid3iconv", line 94, in has_id3v1
    f = open(filename, 'rb+')
IOError: [Errno 21] Is a directory: 'test'

Expected results:

./mid3iconv test 
Not a regular file: test

or whatever error message(s) you like most.

Attachment: mid3iconv-fedora-641591.patch

Original issue: http://code.google.com/p/mutagen/issues/detail?id=79


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From joe.wreschnig@gmail.com on December 30, 2010 02:35:56

Please apply the patch in r99 instead. Asking permission to open the file is bad design because there are too many things to ask.

Summary: mid3iconv: Throws error and halts when destination is a directory
Status: Fixed
Labels: -Type-Enhancement Type-Defect

@lazka lazka added trivial bug labels Apr 7, 2016
@lazka lazka closed this Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.