Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WMA not playable with Winamp/WMP after saving #81

Closed
lazka opened this issue Jul 4, 2014 · 7 comments
Closed

WMA not playable with Winamp/WMP after saving #81

lazka opened this issue Jul 4, 2014 · 7 comments
Labels
bug

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 4, 2014

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


From reiter.christoph@gmail.com on January 22, 2011 10:44:18

https://bugs.launchpad.net/ubuntu/+source/quodlibet/+bug/705936 Affected file attached in the report.

Original issue: http://code.google.com/p/mutagen/issues/detail?id=81


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From joe.wreschnig@gmail.com on January 22, 2011 02:56:31

This looks like a duplicate of issue #60 , fixed in Mutagen 1.20. As a temporary workaround, the embedded picture can be removed (or the file can be loaded and re-saved in 1.20).

Status: Duplicate

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on January 23, 2011 01:41:17

Please reopen.

With any file posted in the report and some files from my library using mutagen trunk:

song = mutagen.File("file.wma")
for tag in song.tags.keys():
    del song.tags[tag]
    song.save()

results in and broken file.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From joe.wreschnig@gmail.com on January 23, 2011 02:10:19

Re-opening.

Status: Accepted
Labels: -Type-Enhancement -Priority-Low Type-Defect Priority-High

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on January 24, 2011 07:19:29

It seems that similar to large objects ( issue 60 ), all ASFGUIDAttribute objects need to be saved as metadata library objects and not as extended content description objects or normal metadata objects.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on January 23, 2011 16:09:34

The header size wasn't updated after saving so it always deleted the difference between the size when it was first loaded and the size of all object. num_objects also needs to be updated, but it wasn't used anywhere so I made it local.

Since this never happens in QL as far as I know, the above report has to be something different. (re-saving, removing embedded pictures doesn't help)

Attachment: mutagen_81.patch

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on October 31, 2012 06:05:49

This issue was closed by revision r138 .

Status: Fixed

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From nick.bou...@gmail.com on October 29, 2012 12:53:00

Attachment: m81.patch

@lazka lazka added trivial bug labels Apr 7, 2016
@lazka lazka closed this Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.