Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown frames are not properly upgraded to ID3v2.4 #97

Closed
lazka opened this issue Jul 4, 2014 · 3 comments
Closed

Unknown frames are not properly upgraded to ID3v2.4 #97

lazka opened this issue Jul 4, 2014 · 3 comments
Labels
bug

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 4, 2014

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


From lalinsky on August 16, 2011 21:58:27

The ID3 parser stores unknown frames as raw bytes, which is a problem if you read them from ID3v2.3 tags and save to ID3v2.4 tags. Particularly, this means that the frame size which was supposed to be 32-bit integer in ID3v2.3 is not converted to the synch-safe integer in ID3v2.4.

See this bug report for an example: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=584420

Original issue: http://code.google.com/p/mutagen/issues/detail?id=97


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on July 20, 2012 14:12:04

This issue was closed by revision r111 .

Status: Fixed

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on April 10, 2012 11:28:54

I see no easy way for recovering old files...

Attachment: 97-convert-23-frames-v1.patch 97-unknown-23-update.mp3

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on July 20, 2012 14:15:39

All frames in ID3.unknown_frames will be upgraded to 2.4 when update_to_v24 is called or thrown away if that fails.
@lazka lazka added trivial bug labels Apr 7, 2016
@lazka lazka closed this Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.