Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collections ABCs deprecation warning #371

Merged
merged 1 commit into from Jan 29, 2019

Conversation

@ksato9700
Copy link
Contributor

ksato9700 commented Jan 29, 2019

With Python 3.7, I got the following warnings.

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

This is a pull request to fix the issue. I tested with 3.7.2 and 2.7.15 and confirmed all the tests passed.

@lazka lazka merged commit 3eee62d into quodlibet:master Jan 29, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
quodlibet.mutagen #20190129.1 succeeded
Details
@ksato9700 ksato9700 deleted the ksato9700:collectionsDeprecationWarning branch Jan 29, 2019
@phw

This comment has been minimized.

Copy link
Contributor

phw commented Oct 17, 2019

Just to mention this somewhere: Luckily for users of mutagen this still works in Python 3.8, even though they threatened us it would stop working 😅. Now the warning says:

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working

@lazka

This comment has been minimized.

Copy link
Member

lazka commented Oct 17, 2019

Oh, right, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.