Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP4: Add support for iTunes HD Video tag #386

Merged
merged 2 commits into from Jun 9, 2019
Merged

Conversation

@JaySandhu
Copy link
Contributor

JaySandhu commented Jun 8, 2019

The atom is named "hdvd", it's an 8 bit integer where:
0 - SD
1 - 720p
2 - 1080p

iTunes and Apple TV refer to it rather than actual resolution info from the video stream, so it's a helpful tag to have.

The atom is named "hdvd", it's an 8 bit integer where:
0 - SD
1 - 720p
2 - 1080p

iTunes and Apple TV refer to it rather than actual resolution info from
the video stream, so it's a helpful tag to have.
@lazka lazka added the enhancement label Jun 8, 2019
@lazka

This comment has been minimized.

Copy link
Member

lazka commented Jun 9, 2019

Thanks. Needs a test (just add it to test_various_int())

@JaySandhu

This comment has been minimized.

Copy link
Contributor Author

JaySandhu commented Jun 9, 2019

I think that covers it. I did some manual testing as well and it works with iTunes and ffmpeg.

@lazka lazka merged commit 273edb8 into quodlibet:master Jun 9, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
quodlibet.mutagen #20190609.2 succeeded
Details
@lazka

This comment has been minimized.

Copy link
Member

lazka commented Jun 9, 2019

Perfect, thanks!

@phw phw mentioned this pull request Nov 18, 2019
1 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.