New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag split: doesn't work on "[foo], bar" #1088

Closed
lazka opened this Issue Mar 15, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@lazka
Member

lazka commented Mar 15, 2015

Original issue 1088 created by van.de.bugger on 2012-12-16T21:52:40.000Z:

I use QL/EF installed from Fedora 17 repos. I also tested current sources download from mercurial repository, and gave the same results.

Ok, I have an album "Six-String Samurai" and want to tag it in EF using MusicBrainz:

  1. Right-click on the first track -> MusicBrainz lookup.
  2. Query: "Six-String Samurai" AND tracks:31
  3. Search. Found 2 results. The first one is ok: Six-String Samurai, Various Artists - 1998, 31 tracks (1 release: 1998: PALMCD2003 (US)).
  4. In the list of tracks I click on the first row, then click Save.

Tags look ok for the first look (but see below):

title: United States of Russia
artist: [dialogue], Red Elvises & Brian Tyler
album: Six-String Samurai
artistsort: [dialogue], Red Elvises & Tyler, Brian
date: 1998
genre: Soundtrack
labelid: PALMCD2003
musicbrainz_albumartistid: ...
musicbrainz_albumid: ...
musicbrainz_artistid: ...
musicbrainz_trackid: ...
tracknumber: 1/31

Ok, let us try lookup it one more time:

  1. Right click on the first song -> MusicBrainz lookup.
  2. Query (pre-filled): "Six-String Samurai" AND artist:"[dialogue], Red Elvises & Brian Tyler" AND tracks:31
  3. No results found.

Why? Since all the tags are properly fulfilled, I would expect the second lookup will be successful. I am not sure what is wrong -- query string or MusizBrainz. I tried to manually edit the query: "Six-String Samurai" AND ( artist:"[dialogue]" OR artist:"Red Elvises" OR artist:"Brian Tyler" ) AND tracks:31. Such a query is successful, but returns only one result (the second one from the first successful query).

BTW, about artist tag:

The first query is successful. The only strange thing is value of the artist field. I would expect it will be 3 artist tags:

artist: [dialogue]
artist: Red Elvises
artist: Brian Tyler

since preferences "split on" is: "/ & ,".

If I right-click on the artist tag and "Split into Multiple Values" result will be:

artist: [dialogue], Red Elvises
artist: Brian Tyler

It is not clear why "[dialogue]" and "Red Elvises" are not splitted. If I right-click on the first artist again, "Split into Multiple Values" is grayed out.

BTW, artistsort from the first query looks strange:

artistsort: [dialogue], Red Elvises & Tyler, Brian

I would expect 3 tags:

artistsort: [dialogue]
artistsort: Red Elvises
artistsort: Tyler, Brian

Ok, let me try split it:

Right-click -> "Split into Multiple Values" gives:

artistsort: [dialogue], Red Elvises
artistsort: Tyler, Brian

Right-click on the first -- "Split into Multiple Values" is grayed out. But right-click on the second gives:

artistsort: [dialogue], Red Elvises
artistsort: Tyler
artistsort: Brian

I think such behaviour is a bit strange.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #1 originally posted by reiter.christoph on 2012-12-16T23:22:11.000Z:

Thanks for the detailed report.

  1. Why isn't the full query succesful?:

The mentioned release is filed in mb under "Various Artists".
QL does not have "Various Artists", it just lists all artists.

We could add a "or artist:'Various Artists'" in case there are multiple ones.

The main usecase for the plugin is a minimal tagged album, so just remove some constrains to get better results. The plugin also needs a rewrite for the "new" Musicbrainz NG API. These multi artist queries might be better handled there.

  1. Why isn't "[dialogue], Red Elvises & Brian Tyler" split in three?

QL expects one separator per tag. It will use the first found from the split preference AFAIR. Do another "split" on the second value.

  1. artistsort: The tag values have no defined order, so there is no way to connect the right artist value with the right artistsort value. This means we can only use one value (all three together) for sorting and splitting sort tags will not change that.

Feel free to post here if anything is still unclear.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #2 originally posted by van.de.bugger on 2012-12-17T19:58:36.000Z:

Thanks for reply. Yes, I still have some questions.

  1. Why isn't "[dialogue], Red Elvises & Brian Tyler" split in three?
    QL expects one separator per tag. It will use the first found from the split preference AFAIR. Do another "split" on the second value.

I am using Ex Falso. "Split on" is set to (default?) value "/ & ,". Current value of "artist" tag is "[dialogue], Red Elvises & Brian Tyler". The first "Split into Multiple Values" splits it to "[dialogue], Red Elvises" and "Brian Tyler". Up to now, everything goes as you described above. But doing "another split" on the first part ("[dialogue], Red Elvises") by "Split into Multiple Values" is not possible -- this item in context menu is grayed out (e. g. not available). Why? There is comma in the value, and comma is present in "Split on" setting.

It seems Ex Falso treats "[dialogue]" in some special way. If I remove brackets, "dialogue, Red Elvises" splits into "dialogue" and "Red Elvises" successfully. But operation is not available for "[dialogue], Red Elvises". "[dialogue]" is a "Special purpose artist" on MusicBrainz (there are some more special artists: "[anonymous]", "[unknown]", "[no artist]", "[traditional]", etc), so splitting should work I think.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #3 originally posted by reiter.christoph on 2012-12-19T08:27:43.000Z:

You are right. That's a bug I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment