Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Tag split: doesn't work on "[foo], bar" #1088
Original issue 1088 created by van.de.bugger on 2012-12-16T21:52:40.000Z:
I use QL/EF installed from Fedora 17 repos. I also tested current sources download from mercurial repository, and gave the same results.
Ok, I have an album "Six-String Samurai" and want to tag it in EF using MusicBrainz:
Tags look ok for the first look (but see below):
title: United States of Russia
Ok, let us try lookup it one more time:
Why? Since all the tags are properly fulfilled, I would expect the second lookup will be successful. I am not sure what is wrong -- query string or MusizBrainz. I tried to manually edit the query: "Six-String Samurai" AND ( artist:"[dialogue]" OR artist:"Red Elvises" OR artist:"Brian Tyler" ) AND tracks:31. Such a query is successful, but returns only one result (the second one from the first successful query).
BTW, about artist tag:
The first query is successful. The only strange thing is value of the artist field. I would expect it will be 3 artist tags:
since preferences "split on" is: "/ & ,".
If I right-click on the artist tag and "Split into Multiple Values" result will be:
artist: [dialogue], Red Elvises
It is not clear why "[dialogue]" and "Red Elvises" are not splitted. If I right-click on the first artist again, "Split into Multiple Values" is grayed out.
BTW, artistsort from the first query looks strange:
artistsort: [dialogue], Red Elvises & Tyler, Brian
I would expect 3 tags:
Ok, let me try split it:
Right-click -> "Split into Multiple Values" gives:
artistsort: [dialogue], Red Elvises
Right-click on the first -- "Split into Multiple Values" is grayed out. But right-click on the second gives:
artistsort: [dialogue], Red Elvises
I think such behaviour is a bit strange.
Comment #1 originally posted by reiter.christoph on 2012-12-16T23:22:11.000Z:
Thanks for the detailed report.
The mentioned release is filed in mb under "Various Artists".
We could add a "or artist:'Various Artists'" in case there are multiple ones.
The main usecase for the plugin is a minimal tagged album, so just remove some constrains to get better results. The plugin also needs a rewrite for the "new" Musicbrainz NG API. These multi artist queries might be better handled there.
QL expects one separator per tag. It will use the first found from the split preference AFAIR. Do another "split" on the second value.
Feel free to post here if anything is still unclear.
Comment #2 originally posted by van.de.bugger on 2012-12-17T19:58:36.000Z:
Thanks for reply. Yes, I still have some questions.
I am using Ex Falso. "Split on" is set to (default?) value "/ & ,". Current value of "artist" tag is "[dialogue], Red Elvises & Brian Tyler". The first "Split into Multiple Values" splits it to "[dialogue], Red Elvises" and "Brian Tyler". Up to now, everything goes as you described above. But doing "another split" on the first part ("[dialogue], Red Elvises") by "Split into Multiple Values" is not possible -- this item in context menu is grayed out (e. g. not available). Why? There is comma in the value, and comma is present in "Split on" setting.
It seems Ex Falso treats "[dialogue]" in some special way. If I remove brackets, "dialogue, Red Elvises" splits into "dialogue" and "Red Elvises" successfully. But operation is not available for "[dialogue], Red Elvises". "[dialogue]" is a "Special purpose artist" on MusicBrainz (there are some more special artists: "[anonymous]", "[unknown]", "[no artist]", "[traditional]", etc), so splitting should work I think.