New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editing:id3encoding option is ignored by quodlibet #1290

Closed
lazka opened this Issue Mar 15, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@lazka
Member

lazka commented Mar 15, 2015

Original issue 1290 created by galkinvv on 2013-11-07T18:34:32.000Z:

I'm using quodlibet 3.0.2 with Python 2.7.5+ on Debian ~testing

- What did you try to do?
Start quodlibet for the firts time (to create config file)
Close quodlibet
Set id3encoding = cp1251 in config file
Start quodlibet, add folder with lot of mp3s with cp1251 encoding tags

- What did you expect to happen?
Songs load displaying cyrillic characters for tags.
This DID wok in some previous versions of quodlibet

- What did happen instead?
Songs load displaying "random" latin-1 chars for tags

I debugged the reason of problem: config is loaded in main() with config.init(const.CONFIG)

But this parameter is read from config by the id3FILE class earlier while loading of quodlibet/formats/_id3.py during

from quodlibet import browsers.

The attached quite ugly but simple patch solves the issue for me.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #1 originally posted by reiter.christoph on 2013-11-07T20:12:05.000Z:

<empty>

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #2 originally posted by reiter.christoph on 2013-11-07T20:51:50.000Z:

This issue was closed by revision 16282c5.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #3 originally posted by reiter.christoph on 2013-11-07T20:53:06.000Z:

Thanks for debugging it. I went for reading it later so something like this doesn't happen again by accident.

@lazka lazka closed this Mar 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment