New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set exact rating as number #1383

Closed
lazka opened this Issue Mar 15, 2015 · 10 comments

Comments

Projects
None yet
1 participant
@lazka
Member

lazka commented Mar 15, 2015

Original issue 1383 created by J.Path95 on 2014-04-26T19:39:46.000Z:

The patch adds another entry to the rating submenu, which lets you set the exact rating of one or multiple songs as a number, such that you don't have to use the console to do that.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #1 originally posted by J.Path95 on 2014-04-27T09:32:13.000Z:

Forgot librarian.changed(songs)

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #2 originally posted by J.Path95 on 2014-05-02T15:07:38.000Z:

Minor improvements + the patch is an exported hg commit instead of an unified patch, so it stays applyable.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #3 originally posted by J.Path95 on 2014-05-02T15:08:26.000Z:

Minor improvements + the patch is an exported hg commit instead of an unified patch, so it stays applyable.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #4 originally posted by reiter.christoph on 2014-05-02T17:34:16.000Z:

This seems a bit too specific tbh. On the other hand I'm not a ratings person.

Nick?

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #5 originally posted by J.Path95 on 2014-05-02T18:08:04.000Z:

But some may find it useful and for others it's just one more row in a context menu that they probably never even noticed anyway, since one-click rating works fine for them.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #6 originally posted by J.Path95 on 2014-05-02T19:08:29.000Z:

I could also port it to a plugin, when I have time next week. Probably that would be more appropriate.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #7 originally posted by nick.boultbee on 2014-05-02T21:02:50.000Z:

I agree - a bit of a niche requirement, but it would make a good songsmenu plugin.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #8 originally posted by J.Path95 on 2014-05-08T13:32:17.000Z:

<empty>

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #9 originally posted by reiter.christoph on 2014-05-29T19:37:00.000Z:

This issue was closed by revision 78aa83d.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #10 originally posted by reiter.christoph on 2014-05-29T19:38:41.000Z:

I've fixed a few things for the commit..

@lazka lazka closed this Mar 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment