Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include plugins into the core #1396

Closed
lazka opened this issue Mar 15, 2015 · 7 comments
Closed

Include plugins into the core #1396

lazka opened this issue Mar 15, 2015 · 7 comments

Comments

@lazka
Copy link
Member

@lazka lazka commented Mar 15, 2015

Original issue 1396 created by reiter.christoph on 2014-05-07T22:14:39.000Z:

We should include all plugins into the core.

It would allow:

  • Translations
  • Easier to run the code from source without symlinking plugins
  • Reduce the risk of users using different versions of plugins/core.

The debian maintainer is for it (merge source packages but still keep the quodlibet-plugins "binary" package)

@lazka
Copy link
Member Author

@lazka lazka commented Mar 15, 2015

Comment #1 originally posted by reiter.christoph on 2014-05-08T17:26:54.000Z:

related: Issue #884

@lazka
Copy link
Member Author

@lazka lazka commented Mar 15, 2015

Comment #2 originally posted by nick.boultbee on 2014-05-08T20:31:29.000Z:

Hmmm do you mean:

  1. just removing the quodlibet-plugins (source?) packages,
  2. or do you also propose move the plugin source tree too, e.g. quodlibet/plugins -> quodlibet/quodlibet/plugins
  3. ...or actually porting their functionality as well, i.e. (semi-)removing the entire concept of plugins?

I'm guessing 2 (which sounds good), but it'd be good to know.

Now is also a good time to re-mention Issue #157...

@lazka
Copy link
Member Author

@lazka lazka commented Mar 15, 2015

Comment #3 originally posted by reiter.christoph on 2014-05-08T20:36:38.000Z:

Yes, I mean 2.

@lazka
Copy link
Member Author

@lazka lazka commented Mar 15, 2015

Comment #4 originally posted by nick.boultbee on 2014-05-08T20:53:18.000Z:

:)

@lazka
Copy link
Member Author

@lazka lazka commented Mar 15, 2015

Comment #5 originally posted by reiter.christoph on 2014-05-10T09:13:53.000Z:

Any thoughts on where to put them?

I suggest "/plugins//.py" -> "/quodlibet/quodlibet/plugins/plugins/" (all in one directory)

@lazka
Copy link
Member Author

@lazka lazka commented Mar 15, 2015

Comment #6 originally posted by nick.boultbee on 2014-05-11T19:35:17.000Z:

Hmm. Why put them all in one giant directory though? I'd argue this reduces tidiness.

Also, a directory that'd be (once checked out) .../quodlibet/quodlibet/quodlibet/plugins/plugins seems a bit too close to total insanity for me (and especially for newbies).

However if we kept the sub-directories we could have all subdirs of /quodlibet/quodlibet/plugins (covers, editing, events, gstreamer, playlist, playorder, songsmenu) as meaningful modules, and all files immediately in that directory as code to support plugin management (or perhaps a separate submodule of "management" but that seems a bit unnecessary).

Thoughts?

@lazka
Copy link
Member Author

@lazka lazka commented Mar 15, 2015

Comment #7 originally posted by reiter.christoph on 2014-05-29T19:02:22.000Z:

<empty>

@lazka lazka closed this Mar 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant