New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-clicking a missing song with other songs already queued is very confusing #1400

Closed
lazka opened this Issue Mar 15, 2015 · 6 comments

Comments

Projects
None yet
1 participant
@lazka
Member

lazka commented Mar 15, 2015

Original issue 1400 created by nick.boultbee on 2014-05-14T21:41:26.000Z:

- What did you try to do?

  1. With a library that hasn't been updated for a while
  2. Many things in the queue
  3. Nothing playing
  4. Select a search for some results that you know have been moved / deleted / renamed since the last search
  5. Double-click a song in the songlist
  6. Keep double-clicking to get the song to play

- What did you expect to happen?
No sound, some kind of error about missing song, bad sound, whatever...

- What did happen instead?
Some unrelated song comes on that maybe you'd forgotten about (being in a large queue, possibly on Random play).

On further clicks, different "random" songs keep coming on, till the tenth time when some messages about too many failures.

Yes, a small symbol by the file appears, but it's not really scary enough for new users especially, and not explained anywhere.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #1 originally posted by reiter.christoph on 2014-06-02T15:57:57.000Z:

See revision 6508e48 and revision 7b12c88

Feedback welcome.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #2 originally posted by nick.boultbee on 2014-06-02T20:18:50.000Z:

Great! Thanks.

A couple of ideas if they're possible:

  1. Can we make the error symbol red (this might just be my theme though). Or if not, can we make the stop symbol (square) in the queue not red... it seems bad that the eye is drawn there more than to the errors.
  2. The title and the content of the dialog seem enough - the bold heading (e.g. Resource not found) doesn't seem to add anything to me. Could move the real error to the title, maybe.
  3. Currently the OSD plugin triggers for me - can we catch the errors earlier and suppress any event plugins?
@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #3 originally posted by reiter.christoph on 2014-06-02T22:41:21.000Z:

  1. The song list icon is symbolic, while the queue status one is not. I guess we can make all symbolic.

  2. Those get retrieved from GStreamer and can vary quite a bit (depending on if it's a stream / files / http error code, codec is missing, etc..) Hard to tell if it never adds something. The two message texts could be merged if that helps.

  3. We only get errors from GStreamer after we start. We could special case missing files by checking them in Python and do song-started=None instead. Or hide the OSD on an error signal / replace with error message.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #4 originally posted by reiter.christoph on 2014-06-03T09:13:16.000Z:

  1. revision 346dc54
@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #5 originally posted by reiter.christoph on 2014-06-03T10:07:30.000Z:

  1. revision 9e5811b
@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #6 originally posted by reiter.christoph on 2014-06-03T10:30:55.000Z:

  1. revision 726f7c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment