Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Play Order rework #1411
Original issue 1411 created by reiter.christoph on 2014-06-06T18:19:31.000Z:
Meta bug for play order changes...
Current design: http://f.666kb.com/i/cozwusc91t7xzr57s.png
We can implement that on top of the current interface by grouping all orders in two groups... a good first step I guess. For the things below we probably need two kinds of plugins, orders and order wrappers.
The queue could have:
Other bugs which should be considered:
Comment #2 originally posted by nick.boultbee on 2014-06-07T08:35:11.000Z:
Sounds interesting. Still working out how / whether this covers all those Issues reports but sounds like it probably does.
To me the primary change needed would be moving from QL having no idea what's ahead of the queue, to pre-filling [the queue, or some meta-queue], which makes Issue #1407, Issue #894, Issue #703, Issue #903 much easier. That and/or keeping a proper history of songs maybe.
Comment #3 originally posted by reiter.christoph on 2014-06-14T06:34:09.000Z:
See revision d782ec3 for the initial UI changes.
It's a bit confusing that the menu changes depending on the toggle state of the button... On the other hand it should be easier to use shuffle/inorder for new users and it's clearer which play order is a shuffle one and which is not.
Another improvement is that external interfaces (mpris, mpd) can now toggle between shuffle/inorder without QL forgetting the previous order.
Comment #4 originally posted by nick.boultbee on 2014-06-14T09:59:55.000Z:
Looks really good, and feels much friendlier / more intuitive to newbies as well (probably!)
A few ideas:
Anyway good stuff, excited to see this long-awaited reworking :) Let me know if there's anything I can help with.
Comment #5 originally posted by reiter.christoph on 2014-06-14T10:45:58.000Z:
Comment #6 originally posted by nick.boultbee on 2014-06-14T13:42:37.000Z:
The closer I get to a refactoring path the more Kafkaesque the codebase seems. So some collected thoughts / plan: