New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album art (cover) downloader saves images with .mp3 extension #1435

Closed
lazka opened this Issue Mar 15, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@lazka
Member

lazka commented Mar 15, 2015

Original issue 1435 created by engored on 2014-08-02T06:00:38.000Z:

In Album Art Downloader window, if I try and save an image for current song (let's say the filename select is on folder.jpg, although it works with any choice) in the song folder I get a new file "folder.jpg.mp3" (.mp3 gets appended). When I try saving the image once again, the Overwrite? dialog displays the name with .mp3 too (so in this case, "The file filder.jpg.mp3 already exists. Overwrite?").

I'm running quodlibet from trunk:

$ hg sum
parent: 6870:d39b9cfd1dfa
Update download page
branch: default

I have only 2 other extensions enabled (notifications and tray icon).

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #1 originally posted by nick.boultbee on 2014-08-02T13:34:56.000Z:

Confirmed - looks like a regression.

Thanks for the report.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #2 originally posted by nick.boultbee on 2014-08-02T16:11:08.000Z:

This issue was closed by revision 0f60b37.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #3 originally posted by nick.boultbee on 2014-08-16T16:32:31.000Z:

This issue was closed by revision 3349cd6.

@lazka lazka closed this Mar 15, 2015

declension added a commit that referenced this issue Apr 8, 2015

New pattern formatter that ignores the song's file extension.
  * Use this in the Album Art downloader
  * Share some tests, hack apart slightly, and add some more focused on album art.

 Fixes Issue #1435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment