New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n issues and more #1442

Closed
lazka opened this Issue Mar 15, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@lazka
Member

lazka commented Mar 15, 2015

Original issue 1442 created by engored on 2014-08-06T15:54:06.000Z:

While preparing the translation update, I've been writing down things that could be improved. Most are minor issues, so I'm putting them all in this ticket, sorry if that'll turn up inconvenient. Also, some are not bugs, but recommendations from a translator's point of view. The notes were written over a week, so some issues may be already fixed or line numbers changed.

  • album art downloader window is not wide enough by default to show controls entirely
    Running in a LANG=C environment, for example, shows that the window width is just barely enough for unlocalized controls and labels
  • ext/_shared/squeezebox/base.py & friends: "couldn't {connect,talk} to %s" then %s gets resolved as "Squeezebox server at ..."
    Having a "split" message like this makes it hard/fragile to get declension/conjugation right
  • ext/events/animosd.py: effect names ("Shadow", "Outline") are not translatable
  • ext/events/notify.py:192: checkbox label shows literal "_" ("...is not _focused")
  • ext/events/qlscrobbler.py: "Other..." is not translatable
  • ext/events/write_cover.py: "File" label is centered, not consistent with other config panes, steals useful space
  • ext/gstreamer/karaoke.py:22: are slider values in Hz? Not labeled at the moment. Makes it hard to understand the effect of sliders. "Width" slider feels as acting in inverse?
  • ext/playorder/follow.py:20: description is not translatable
  • ext/sondsmenu/ape2id3.py: extension description is not translatable
  • ext/songsmenu/custom_commands.py: "Command" label in editor window is not translatable
  • ext/songsmenu/embedded.py:66: embed current image(s), delete image(s) is hard to translate
    Having an (s) meaning "image or images" may be hard to translate and not get an overly long message. Can a song have multiple cover pictures?
  • ext/songsmenu/exact_rating.py:27: scale from 0 to 1
    Just a nitpick, but shouldn't it be from 0.0 to 1.0?
  • ext/songsmenu/fingerprint/init.py:47: extra whitespace
  • ext/songsmenu/refresh.py:24: %d songs is not plural
    The message should be wrapped in a ngettext(), but isn't.
  • ext/songsmenu/refresh.py{16,24}: Refresh {S,s}ongs
    Two very similar messages. Typo? I didn't see the lowercase variant in the interface.
  • ext/songsmenu/wikipedia.py:37: "Search at http://..." is not translatable
  • ext/songsmenu/website_search.py:104: "Supports QL patterns..." tooltip is more useful on an actual input
    Now the tooltip is on a button opening editor window.
  • qltk/maskedbox.py:65: %(song_count)d songs is not plural
    Again, ngettext() is not used.
  • qltk/msg.py:55:"Are you sure?"
    Please avoid such dialogs if you can.
  • qltk/prefs.py:322: ReplayGain-related labels are centered; not consistent, looks strange
  • qltk/prefs.py:613: period (full stop) in a weird place
  • qltk/songlist.py:319: "_Filter on %s" for multiple items?
    Accelerators will inevitably clash.
  • qltk/songlist.py:1010: "_Expand" on a column
    Isn't self-explanatory, considering the rest of context menu list is related to the whole song list, not specific column. Something in a sense of "_Expand column" would be better here.
@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #1 originally posted by reiter.christoph on 2014-08-06T15:58:32.000Z:

very helpful, thanks!

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #2 originally posted by reiter.christoph on 2014-08-11T13:14:21.000Z:

This issue was closed by revision 0313876.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #3 originally posted by reiter.christoph on 2014-08-11T13:46:05.000Z:

I hope I got everything. I've given you push rights now, so if you want you can fix things yourself in the future; but you don't have to of course, whatever is easier for you...

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #4 originally posted by engored on 2014-08-11T14:01:18.000Z:

Thanks! I continue making notes preparing the next update, and depending on the issues, maybe I'll push some changes really carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment