New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the plugin names and descriptions are not translatable #1445

Closed
lazka opened this Issue Mar 15, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@lazka
Member

lazka commented Mar 15, 2015

Original issue 1445 created by engored on 2014-08-13T04:08:24.000Z:

Even though some of the names will probably not be translated (e.g. "JEP-118"), I think it shouldn't be a special case, and it wouldn't hurt anyway. I'll submit the patch soon.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #1 originally posted by engored on 2014-08-13T04:11:35.000Z:

This patch wraps every last PLUGIN_NAME and PLUGIN_DESC strings in _().

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #2 originally posted by engored on 2014-08-13T04:13:39.000Z:

Maybe I should have just committed this instead of opening an issue, but... anyway, the patch is hg import-ready.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #3 originally posted by reiter.christoph on 2014-08-13T06:26:01.000Z:

This issue was closed by revision 7356eec.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #4 originally posted by reiter.christoph on 2014-08-13T06:26:19.000Z:

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment