New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratings are not stored in tags (tested with mp3 and FLAC) #1461

Closed
lazka opened this Issue Mar 15, 2015 · 12 comments

Comments

Projects
None yet
4 participants
@lazka
Member

lazka commented Mar 15, 2015

Original issue 1461 created by joschuaga@yahoo.de on 2014-08-30T14:19:07.000Z:

The plugin "Force Write" and "saving rating and play count" are enabled. I use "Banshee" as the email, because I hoped that I could get my old ratings (made by Banshee) this way, but it doesn't seem to work.

- What did you try to do?
I rated something and then checked with mutagenx if the tags for rating are correctly set.

- What did you expect to happen?
I expect it to set the rating tag.

- What did happen instead?
It didn't set the rating tag. (On one mp3 file the rating and the play count was set, but it was 0 instead of the expected 255, because I voted it 4 of 4 stars.)

- Which version of Quod Libet?
3.2.1

- Which operating system including version (Ubuntu 14.04, Win7, Debian
sid)?
Ubuntu 14.04 / 64bit

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #1 originally posted by reiter.christoph on 2014-08-31T20:30:35.000Z:

I can't reproduce.

but I see some possible errors if the rating is set to the default rating... what do you have set as default?

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #2 originally posted by joschuaga@yahoo.de on 2014-09-01T20:33:50.000Z:

I have set the default (2 stars = 0.5) as the default rating.

Could it have to do with using "Banshee" as the email, which really isn't an email?

Maybe you could try to change your "email" and then rate something unrated and see if it really has been set.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #3 originally posted by joschuaga@yahoo.de on 2014-09-09T12:37:37.000Z:

Christoph - Could you find anything?

Slightly related:

Is it possible to "import" or use the Ratings & Playcounts that were made by Banshee?

For example I have FLAC file that has been rated the best rating and a playcount of 1. This is what it looks like if I use pprint of mutagenx:

FLAC, 82.40 seconds, 44100 Hz (audio/x-flac)
TITLE=Fugue #7777
ARTIST=Asuka Sakai
ALBUMARTIST=Various Artists
ALBUM=Katamari Fortissimo Damacy
DATE=2004
TRACKNUMBER=5
GENRE=Game
COMPILATION=1
RATING:BANSHEE=1.0
PLAYCOUNT:BANSHEE=1

but these are not shown in Quod Libet.

@lazka lazka removed the priority-normal label Mar 15, 2015

@pdesanex

This comment has been minimized.

pdesanex commented Jun 2, 2015

I'm having the same issue. QL doesn't store ratings / playcounts, neither in MP3s, nor in FLACs. My rating scale is set to 5, default rating to 0. The Email field is set to a non-standard address, but it doesn't seem to work with a proper email address either. Ratings / playcounts from banshee are displayed in the QL tag editor, but, as far as I remember, they are not picked up as such in QL.

@CreamyCookie

This comment has been minimized.

Contributor

CreamyCookie commented Aug 11, 2015

@lazka In my original bug report I didn't realize that I have to execute Force Write on each song for which the ratings should be stored. If I use the plugin this way, the ratings seem to be stored.

So the question is: Is there a way to run a plugin whenever ratings or playcount change (I need both)?

And slightly related: Can a plugin be executed whenever albums are added? I'd like to automatically add ReplayGain tags to any new albums.

@declension

This comment has been minimized.

Member

declension commented Sep 13, 2015

And slightly related: Can a plugin be executed whenever albums are added? I'd like to automatically add ReplayGain tags to any new albums.

@CreamyCookie we talked about this ages ago actually. Short version: currently: no, but it's definitely a feature I'd like (especially when combined with the work in the watched-library branch (see #1315)

On further digging, see #275 for that exact use case.

@CreamyCookie

This comment has been minimized.

Contributor

CreamyCookie commented Nov 16, 2015

Okay, this is weird. When I rate a song 0.5 = 2 stars, and then use the Force Write plugin on a FLAC file (haven't tried a mp3 yet), the rating isn't stored. However, as soon as I set it to any other rating, it's stored. When I then set it to 0.5 again, it isn't stored in the tags. (I used mutagen to check if it contains the ratings tag.) Do you have any idea what is going here?

(The ratings and playcounts are one of the most important metadata for me. I use them for making playlists, which I then export to my USB stick.)

@lazka

This comment has been minimized.

Member

lazka commented Nov 18, 2015

Yes.. some time ago QL didn't have an "unset" state for ratings and used the default instead.

@CreamyCookie

This comment has been minimized.

Contributor

CreamyCookie commented Nov 18, 2015

Interesting.

So, as a temporary fix, could I set the default value to something like 0.3141592653589794 in the settings, and force write my whole library, so it will also store ratings of 0.5 in the tags?

Edit: Sadly that doesn't work, because after editing the config file, Quodlibet resets the default to 0.25. :(

@lazka What would it take to fix this bug?

Could I just replace:

if rating != RATINGS.default:

with

if rating is not None:
@CreamyCookie

This comment has been minimized.

Contributor

CreamyCookie commented Dec 11, 2015

Any feedback on this?

@lazka

This comment has been minimized.

Member

lazka commented Dec 11, 2015

Any feedback on this?

I've added some API in ca53d77 for this

@CreamyCookie

This comment has been minimized.

Contributor

CreamyCookie commented Feb 22, 2016

@lazka

Thanks!

@lazka lazka closed this in 08b6e3f Feb 23, 2016

lazka added a commit that referenced this issue Feb 23, 2016

Merge pull request #1846 from CreamyCookie/default-rating-fix
Fixes #1461: Store ratings in the tags, even if they're the default value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment