Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Import ratings, play counts from Rhythmbox #1463
Comment #3 originally posted by reiter.christoph on 2014-09-04T08:50:33.000Z:
and hopefully it works, if not please report
Comment #4 originally posted by philhudsonster on 2014-09-04T17:53:40.000Z:
Traceback (most recent call last):
I see in one of the built-in plugins a statement importing expanduser from quodlibet.util. I'll try making that change myself and report back.
Comment #6 originally posted by philhudsonster on 2014-09-04T18:15:37.000Z:
Runs now. Thanks, you're incredible. That was such a fast turnaround!
First thought: although it's very fast, it does go over the 8-second limit they taught me about in UX grade school for my 10000+ songs; maybe a progress bar? At least a busy cursor.
Second: After the import finishes, every song with a rating in RB (there are a few unrated) is displayed in QL with four stars, irrespective of the rating in RB. It looks to me like the variable 'stats' (a map?) is not being initialized or populated anywhere, but my Python-fu is pretty rudimentary so that's just a guess.
Comment #7 originally posted by philhudsonster on 2014-09-04T18:17:45.000Z:
I'm on Linux Mint Debian Edition, which is a "rolling release" based on Debian Testing -- likely to be up to six months behind current. The installed version of QL is 3.0.2. Here's what the "About..." dialog says:
Supported formats: FLAC, MIDI, MOD/XM/IT, MP3,
Audio device: GStreamer (autoaudiosink)
Comment #9 originally posted by philhudsonster on 2014-09-04T18:30:44.000Z:
If I understand the algorithm design in method _process_song (big if; as I say, I'm not a Pythonist), then I think it might be smartest to subtract 1 from the RB rating (1 to 5 stars) when converting to a QL rating (1 to 4). It may be that there is no single "right" way to map from one to the other, but that would suit my collection and what the ratings mean in my head.
Comment #11 originally posted by philhudsonster on 2014-09-04T21:08:08.000Z:
OK, I switched to your Debian repo and this rev of the plugin.
Dude... you rock!
That is one of the fastest, if not the fastest, RFE turnarounds I've ever seen, with the main delay being me getting back to you. I am so impressed.
For utter perfection, you would do that waiting/watch/hourglass-cursor thing I mentioned, but this is good enough for me. Thank you very much.
Comment #14 originally posted by nick.boultbee on 2014-09-05T10:30:46.000Z:
+1 (though haven't tested myself yet): great work Christoph (again!).
I think we could do well once this is stable by publicising it, possibly as part of the overall initial user experience - after yet another O/S reinstall I've been alerted to that again (good ol' Issue #1090).
Without wanting to push potential users too much, RB is almost the iTunes of the modern Linux space, and I think encouraging these new users [to migrate to the awesomeness of QL], this kind of thing would really help (c.f. Jetbrain's very smooth and successful support for transitioning from Eclipse -> IntelliJ IDEA in the Java IDE space)
As a starter I can help update docs / site pages too, as soon as I get a bit of time...