Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
ReplayGain plugin: manage existing RG tags better #1471
- What did you try to do?
I used the ReplayGain plugin on a folder that already had it's ReplayGain tag set (actually by the plugin itself a minute or so before).
- What did you expect to happen?
I expected the plugin to skip (in this case mp3) files that already had it set (or that there would be a checkbox to rescan files).
- What did happen instead?
As the progress bar indicated it rescanned the files. (I want to add ReplayGain to my whole mp3 / flac / ogg library and this would increase the amount of time immensely.)
- Which version of Quod Libet?
- Which operating system including version (Ubuntu 14.04, Win7, Debian
Ubuntu 14.04 / 64bit
Comment #2 originally posted by reiter.christoph on 2014-09-26T11:07:20.000Z:
Yeah, we could add an option. Thanks for the report.
You could also use replaygain_album_gain="" in the album browser to get untagged ones in the meantime.
Re github etc: Yeah, not being able to edit is the thing I miss the most here. I guess we will switch some time. Atm I'm not annoyed enough to do the work (migrating bug reports etc.)
Comment #3 originally posted by nick.boultbee on 2014-09-26T12:33:37.000Z:
Agreed that it could be better for some users (though I also use an equivalent to Christoph's query, so it doesn't affect me much).
If we did it (I'll have a look as soon as I get some free time), I'd suggest a global plugin config drop-down for behaviour and keeping the default is "replace existing" (possible interesting additions: "alert on [significant] change").
Thanks for the replaygain_album_gain="" trick! :)
I've found some information to automate migrating issues from Google Code to GitHub / BitBucket: https://answers.atlassian.com/questions/297709/migrating-issues-from-google-code-to-bitbucket
Maybe this could help. The code seems to be easy to migrate, but you probably knew that:
Comment #7 originally posted by reiter.christoph on 2014-12-17T13:57:02.000Z:
Please fix "./setup.py quality"
You can use util.cached_property here if you need caching.
I'm wondering why someone would not want to override existing values?
The properties return a mix of str/float and are unused afaics, please
Comment #8 originally posted by nick.boultbee on 2014-12-17T17:40:56.000Z:
Thanks again for the review.