New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue play order wrong after moving song #1496

Closed
lazka opened this Issue Mar 15, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@lazka
Member

lazka commented Mar 15, 2015

Original issue 1496 created by renemaur on 2014-11-18T08:50:23.000Z:

What did you try to do?

  1. Start QL (playlist view, empty queue).
  2. Pause current song.
  3. Add 5 songs to the queue.
  4. Press next => top song from queue is played.
  5. Press next again => top song from queue is played.
  6. Go to queue and move the last song on top of the queue.

What did you expect to happen?
7. Press next => (new) top song from queue is played.

What did happen instead?
7. Press next => second song from queue is played.

Which version of Quod Libet?
3.2.2

Which operating system including version (Ubuntu 14.04, Win7, Debian
sid)?
# uname -sro
# Linux 3.17.3-1-ARCH GNU/Linux

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #1 originally posted by reiter.christoph on 2015-02-10T08:22:25.000Z:

Thanks.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #2 originally posted by reiter.christoph on 2015-02-12T18:51:10.000Z:

This issue was closed by revision 5af9a19.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #3 originally posted by reiter.christoph on 2015-02-12T18:51:21.000Z:

That broke things.. revert.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #4 originally posted by reiter.christoph on 2015-02-12T20:17:11.000Z:

This issue was closed by revision 8a29665.

@lazka lazka closed this Mar 15, 2015

lazka added a commit that referenced this issue Apr 8, 2015

queue: (real fix) don't decide on the next song too early. Closes issue
#1496.

Selecting a song from the queue dependend on the previous hacky behaviour.
We now explicitly tell the player to select a song from the queue..
not nice, but at least the hack is visible now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment