Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
notify plugin: album art not working under e19 #1504
Original issue 1504 created by reiter.christoph on 2014-12-15T20:15:40.000Z:
Comment #1 originally posted by gandalf.pk on 2014-12-15T20:28:38.000Z:
It turns out that the "URI.frompath(image_path)" junks the image_path (filling it with %20 instead of spaces), manually doing something like:
image_path = "file://" + song.find_cover().name
seems to work just fine. I guess until I hit something nasty and it crashes.
Also, for some reason, the:
if "icon-static" in caps
sequence doesn't follow through (on E19).
Comment #2 originally posted by reiter.christoph on 2014-12-15T21:02:56.000Z:
Spaces aren't allowed in file URIs and image_path is defined as a file URI according to the notification spec .
Maybe putting the URI in the hints field helps 'hints["image-path"] = image_path'? (besides removing the "icon-static" check)
Comment #3 originally posted by gandalf.pk on 2014-12-15T22:16:42.000Z:
Actually, just removing the check seems to work fine, passing the actual absolute location instead of an URI works.
The "spec" is equal to [1, 2] in E19, by the way - not sure why it doesn't pass "spec >= (1,1)"...
I wonder, is "icon-static" not being listed in capabilities a bug in E19? Should I report it there?
Comment #4 originally posted by reiter.christoph on 2014-12-15T22:40:35.000Z:
Not sure why I checked for "icon-static" there. It's not clear to me what it's for exactly according to the spec (any ideas?). I guess it can be removed.
For the image path we can't change that format since that would break other notification implementations.
Did setting "image-path" to the URI in hints not help?
Is e19 in the default arch repo?