New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the context menu of the current song under "Control" in the menu bar #1527

Open
lazka opened this Issue Mar 15, 2015 · 8 comments

Comments

Projects
None yet
1 participant
@lazka
Member

lazka commented Mar 15, 2015

Original issue 1527 created by joschuaga@yahoo.de on 2015-01-25T10:57:10.000Z:

When listening to a playlist (e.g. with songs from different albums), while searching through the music library, this would greatly reduce the steps required to, for example, rate the current song or add it to a playlist. (Normally you would press Ctrl + J, select the song, right click, select rating and find, then select the album you were looking at before.)

This would fit nicely together with to option to jump to the current song.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #1 originally posted by reiter.christoph on 2015-01-25T11:02:12.000Z:

We do expose some actions in the context menu of the main info label at the top, and both your described actions are there.

But yeah, it's a bit hard to find, and not all is there.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #2 originally posted by joschuaga@yahoo.de on 2015-01-25T18:27:47.000Z:

Cool! I'm still finding awesome features about this player, like being able to edit the title. Great work :)

Could the normal context menu instead be displayed in place of the current limited version? This might simplify some code and also allow for using the other options missing in the limited context menu, like using a plugin on the current song or finding all albums from the artist.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #3 originally posted by nick.boultbee on 2015-01-26T12:39:30.000Z:

Yeah, I've often wondered why we don't allow plugin menus in the info area, but so used to it now haven't thought about changing it. Off the top of my head it would be pretty easy, but there may be some gotchas.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #4 originally posted by reiter.christoph on 2015-01-26T13:13:33.000Z:

There are three parts, the full song menu, the menu items for text selection and the "Edit display" menu item.

One idea:

When text is selected show the GtkLabel menu but append a "Current song" submenu pointing to the song menu.
When no text is selected show the full song menu as is.

The remaining question is where to put the "Edit Display" item. Maybe put it in the preferences so it easier to discover, or the main menu bar, or leave it there...

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #5 originally posted by spxxxk on 2015-01-26T13:19:35.000Z:

Looks related to issue #757.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #6 originally posted by nick.boultbee on 2015-01-26T15:39:48.000Z:

spxxxk - yep, that's where I remember it from... :)

Thanks, and +1 for this.

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #7 originally posted by joschuaga@yahoo.de on 2015-01-26T19:09:07.000Z:

Seems reasonable :)

I have two questions regarding the "menu items for text selection":

  • Do they have to be shown, when no text is selected?
  • Are "Cut", "Delete" and "Paste" of any use?

I think putting "Edit display" in preferences would make sense, since it isn't something that will be changed very often.

The "context menu of the current song" should appear both on right click on the "play area" and in the menu bar, because the former only works and is more efficient then the menu bar, with a mouse.

The latter (menu bar), on the other hand, is much more efficient with a keyboard. (Especially if using Ubuntu Unity, where you can search through the menu bar by pressing ALT.)

@lazka

This comment has been minimized.

Member

lazka commented Mar 15, 2015

Comment #8 originally posted by reiter.christoph on 2015-02-13T10:23:10.000Z:

made some changes in revision 44e7934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment