New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation script does not respect --install-data #1575

Closed
pyromaniac2k opened this Issue Apr 11, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@pyromaniac2k

pyromaniac2k commented Apr 11, 2015

The setup.py script has a parameter called "--install-data" to specify the installation directory for data files. Instead of using that directory, the datafiles all end up intalled in prefix/share, which is bad when you use a prefix different from /usr.

@lazka

This comment has been minimized.

Member

lazka commented Apr 14, 2015

Thanks. Which files for example, and why do you need them at a different path?

@lazka lazka added the needinfo label Apr 14, 2015

@pyromaniac2k

This comment has been minimized.

pyromaniac2k commented Apr 14, 2015

we use /usr/x86_64-pc-linux-gnu/ as prefix instead of just /usr, but all the arch-independent files should still be in /usr/share.

This concerns all desktop files, man pages, locale, pixmaps, dbus-service file and appdata xml files.

@lazka

This comment has been minimized.

Member

lazka commented Apr 15, 2015

Thanks, I'll have a look. (Everything in QL is arch-independent btw)

@lazka lazka added bug confirmed and removed needinfo labels Apr 15, 2015

@lazka lazka closed this in 092e7fc Apr 15, 2015

@lazka

This comment has been minimized.

Member

lazka commented Apr 15, 2015

Would you like this to be backported for 3.4.1?

@pyromaniac2k

This comment has been minimized.

pyromaniac2k commented Apr 16, 2015

Thank you for that fix. Yes, having that patch in 3.4 would be nice.

@lazka

This comment has been minimized.

Member

lazka commented Apr 16, 2015

Ok, will do. And any feedback on the packaging guide [0] is welcome.

[0] https://quodlibet.readthedocs.org/en/latest/packaging.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment