New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up application menu #1598

Closed
CreamyCookie opened this Issue Apr 29, 2015 · 11 comments

Comments

Projects
None yet
3 participants
@CreamyCookie
Contributor

CreamyCookie commented Apr 29, 2015

The current application menu has some redundancies and some items that aren't ordered semantically. Here's my suggestion:

  • Quod Libet
    • Preferences
    • Plugins

    • Online Help
    • Search Help
    • About

    • Quit
  • View # no change
  • Library
    • Add a file
    • Add a folder
    • Add a location

    • Refresh Library
    • Search Library
  • Filters # no change
  • Control
    • Previous
    • Play
    • Next
    • Stop after this song
  • Current song
    • Jump to playing song
    • Add bookmark
    • Edit bookmark

    • Edit Tags
    • Information

Related enhancements / bugs:

  • #1527 - Add the context menu of the current song under "Control" in the menu bar
  • #1601 - "Filter on genre" is missing in the context menu of the current song
  • #1602 - Add all "saved searches" to the "Filters" submenu in the menu bar
@declension

This comment has been minimized.

Member

declension commented Apr 30, 2015

Some good points there (having a Library top-level menu makes a lot of sense), and a few that don't work for me.

@CreamyCookie, do you think you could split this ticket into logically distinct tasks, as there are too many things to implement for this to get done any time soon.

@CreamyCookie

This comment has been minimized.

Contributor

CreamyCookie commented Apr 30, 2015

@declension Thanks!

  1. I would leave this bug report here and extract / create the following 2 additional ones. Is that okay with you? Or (what) more?
    • Append saved searches in "filters" application menu (including the current 4 default ones: all, recently played, recently added, top40)
    • "Filter on genre" is missing in the context menu of the current song
  2. Which are the points you don't like? Maybe I can convince you (or you me).. 😉
@declension

This comment has been minimized.

Member

declension commented May 1, 2015

@CreamyCookie that sounds great. Perhaps reduce this ticket to being about a Library top-level menu and add others as necessary.

@lazka and I agreed recently that extra top-level menus should probably be avoided if possible (there are already enough), especially with Ubuntu (15) adding its own (currently).

@lazka

This comment has been minimized.

Member

lazka commented May 1, 2015

The Ubuntu menu is gone now #1599. For a plugin menu we have #152

Here is the Gnome HIG btw: https://developer.gnome.org/hig/stable/menu-bars.html.en
(but given that Gnome is moving away from menu bars, ignoring it shouldn't do much harm)

@CreamyCookie

This comment has been minimized.

Contributor

CreamyCookie commented Aug 11, 2015

@declension Is this report okay the way it's now?

@declension declension self-assigned this Jul 5, 2016

@declension

This comment has been minimized.

Member

declension commented Jul 5, 2016

Continuing on from here and points raised in #1716, #1943, and to a lesser extent #1931, #1046...

With some fresh perspective I realised more than ever how confusing some of the QL menus are, and am currently experimenting with a more standard setup, with similarities to the above from @CreamyCookie :

Revised structure

File, Edit, View, Browse, Control, Help.

  • File is essentially Music minus the secondary browser item
  • Edit has Edit Tags, Bookmarks (one day maybe: Lyrics..)
  • View as before without Browsers, but with Information (TODO: clean-up / split / improvement of this)
  • Browse has just the browser-related items
  • Control is as before, with Filters as a sub-menu
  • Help is as before

This is only one more menu than previously, so not too much horizontal bloat as feared, and conforms more with the Gnome HIG @lazka mentioned above.

Benefits

  • Editing of tags is no longer under the view menu
  • Filters merged into control, as to me browser selection (etc) feels much more important
  • Add bookmark gone - I'd venture it was rarely used (try it...)
  • Changing the primary browser and launching a new browser are now in the same place (browsing..)
  • Launching the secondary is at the top, for UX improvement.
  • Disable browser gone (see other ticket)
  • View options are simpler - the songlist is always visible as it's too confusing for new (and old) users when it disappears, IMO, but can reinstate it if anyone really misses it. Edit: Reverted that for now, can do it separately.
@CreamyCookie

This comment has been minimized.

Contributor

CreamyCookie commented Jul 5, 2016

Great ideas! Just a few points:

Control is as before, with Filters as a sub-menu

I think putting Filters into Browse would fit better since it affects what's displayed in the current browser.

Analogue to that "Jump to playing song" should be also reside in Browse in my opinion.

View as before without Browsers, but with Information

Which elements would View contain?

Editing of tags is no longer under the view menu

Edit tags is in Control for me. Am I missing something?

Browse has just the browser-related items

Maybe it could look similar to this:

  • Browse
    • Individual Songs (still not a perfect name)
    • Paned Browser (would be cool if there was a name without "Browser")
    • Album List
    • Album Collection
    • Playlists
    • ---------------- (separator here because the browsers below have nothing to do with the library)
    • File System
    • Internet Radio
    • Audio Feeds
    • Media Devices
@declension

This comment has been minimized.

Member

declension commented Jul 5, 2016

I think putting Filters into View would fit better since it affects what's displayed in the current browser.

Agree it doesn't belong in Control - I'd actually already moved it to Browse, since as you say it's a browser concern (and in the code too actually). Let's try it there for now

Edit tags is in Control for me. Am I missing something?

Thanks, yes you're right - I've already forgotten what it used to look like! Anyway, in no way does it control (the player).

Paned Browser (would be cool if there was a name without "Browser")

Yes - I was actually considering renaming this Hierarchies. Crazy, at first, but I think it's most appropriate name (panes are a UI concern, and browser, well they're all browsers..)

---------------- (separator here because the browsers below have nothing to do with the library)

Great idea, I'll add that now separately (it's a bit bigger than I thought)

@declension declension added the UI label Jul 5, 2016

@CreamyCookie

This comment has been minimized.

Contributor

CreamyCookie commented Jul 5, 2016

Yes - I was actually considering renaming this Hierarchies. Crazy, at first, but I think it's most appropriate name (panes are a UI concern, and browser, well they're all browsers..)

I like that. Describes perfectly what it does.

declension added a commit that referenced this issue Jul 5, 2016

Complete re-think of application menu (#1598)
 * Disable Browser aka `EmptyBar` is now gone (this fixes some of #1716 etc)
 * Make top-level menus closer to Gnome HIG
 * Add a few missing accels in menu
 * _Filters_ now belongs in _Browse_
 * Simplify menu creation code a bit
 * Browser menu widget accessing is now centralised (to allow easier rethinking of menus..)
 * Update `POTFILES` and documentation
 * Fix some broken tests
@declension

This comment has been minimized.

Member

declension commented Jul 6, 2016

From discussion on IRC:

lazka added a commit that referenced this issue Jul 7, 2016

Merge pull request #1975 from quodlibet/menu-rethink
Complete re-think of application menu (#1598)
@CreamyCookie

This comment has been minimized.

Contributor

CreamyCookie commented Jul 7, 2016

@declension Great work! I really like the new menu. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment