New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display custom tags in custom headers #1660

Closed
MikeiLL opened this Issue Aug 7, 2015 · 6 comments

Comments

Projects
None yet
3 participants
@MikeiLL

MikeiLL commented Aug 7, 2015

It took me a few minutes (a bunch of times) to (finally) figure out how to get my custom tag ("description") to display in my custom header ("Description"). Finally realized that it was the non-matching case of the word that was preventing them getting linked.

Is it likely that folks would want to have multiple tags with the same word capitalized differently or would it make sense to use if (tag.upper() == header.upper()) or similar to avoid this issue? Looks like the header is displayed using str.capitalize().

@declension

This comment has been minimized.

Member

declension commented Aug 10, 2015

Can you describe what you did exactly?

I'm assuming it involved editing the visible columns, then adding Description under the Others list, but finding whilst this looked correct in the songlist headers, it didn't show your description tag values for songs.

The important thing to remember is that you are adding tags to the headers, not their (looked up, localised, and title-cased) descriptions (try albumartist). I see the confusion though here and thanks for the feedback.

Potential mitigations

  1. This should be documented more clearly, perhaps even in-app (tooltips / labels etc) and/or
  2. We could perhaps warn when entering non-lowercase tags to this list as well

I don't think we should make all tag handling case insensitive, and I don't see an efficient way of checking for all combinations of tag value capitalisations (especially across locales)

@lazka

This comment has been minimized.

Member

lazka commented Aug 10, 2015

Another thing might be to show all colums in the "edit others" window. So it's obvious that the current column names and the tags behind them don't match.

@declension

This comment has been minimized.

Member

declension commented Aug 10, 2015

Yes, so it could become more of an "advanced edit" feature, rather than just editing the "additional" (typically non-standard) ones.

Alternatively (or: as well) the widget could had another (read-only) column for Column Heading, naming the current single column as Tag Name.

Adding a tag would still be the same user experience, but even clearer what you'll get before you exit the dialog.

@MikeiLL

This comment has been minimized.

MikeiLL commented Aug 10, 2015

Thanks for your consideration. I agree that it doesn't make sense to force case insensitivity. Just sent pr with a new FAQ that would probably clarify the process.

@lazka

This comment has been minimized.

Member

lazka commented Aug 15, 2015

@declension adding a second column sounds good

@lazka lazka added the enhancement label Aug 15, 2015

@declension declension self-assigned this Aug 15, 2015

lazka added a commit that referenced this issue Aug 16, 2015

prefs: Display all tags in tag list editor not just the non-default o…
…nes. See #1660

This makes it possible to see the tags used and not just their
(possibly translated) display names.
@lazka

This comment has been minimized.

Member

lazka commented Aug 16, 2015

some more changes: 2b8f20e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment