New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quodlibet GtkAccelMap rc-file no longer support switching browsers #1726

Closed
spxxxk opened this Issue Oct 28, 2015 · 7 comments

Comments

Projects
None yet
3 participants
@spxxxk

spxxxk commented Oct 28, 2015

On ubuntu 12.04, ~/.quodlibet/accels included

    (gtk_accel_path "<Actions>/QuodLibetWindowActions/ViewSearchBar" "")
    (gtk_accel_path "<Actions>/QuodLibetWindowActions/ViewPlaylists" "")
    (gtk_accel_path "<Actions>/QuodLibetWindowActions/ViewFileSystem" "")

It looks like they're no longer added in the default accels file on Ubuntu 14.04, and supported if I add them.

Workaround: use Alt+keys ... but not as convenient

@lazka

This comment has been minimized.

Member

lazka commented Oct 29, 2015

Not sure. Maybe it's broken in gtk+ as nothing there uses that feature any more.

@spxxxk

This comment has been minimized.

spxxxk commented Oct 29, 2015

In ubuntu 14.04, the file is

; quodlibet GtkAccelMap rc-file         -*- scheme -*-
; this file is an automated accelerator map dump
;
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/BrowserPanedBrowser" "")
; (gtk_accel_path "<Actions>/QuodLibetFilterActions/RandomArtist" "<Primary>t")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/BrowserFileSystem" "")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/BrowserCollectionBrowser" "")
; (gtk_accel_path "<Actions>/QuodLibetFilterActions/RandomGenre" "<Primary>g")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/BrowserMediaDevices" "")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/Previous" "<Primary>comma")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/Jump" "<Primary>j")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/About" "")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/BrowserAlbumList" "")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/EditBookmarks" "<Primary>b")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/PlayPause" "<Primary>space")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/Next" "<Primary>period")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/BrowserAudioFeeds" "")
; (gtk_accel_path "<Actions>/QuodLibetFilterActions/RandomAlbum" "<Primary>m")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/BrowserSearchBar" "")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/Quit" "<Primary>q")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/StopAfter" "<Shift>space")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/BrowserPlaylistsBrowser" "")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/BrowserInternetRadio" "")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/AddBookmark" "<Primary>d")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/OnlineHelp" "F1")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/AddFolders" "<Primary>o")
; (gtk_accel_path "<Actions>/QuodLibetWindowActions/SearchHelp" "")

Editing (uncomment+set shortcut) still works for those actions. But no "ViewSearchBar" ... actions.

No idea what generates that accels file though.

@CreamyCookie

This comment has been minimized.

Contributor

CreamyCookie commented Nov 10, 2015

Yep, doesn't work for me either. Although this might be Ubuntu's fault. I can only hope that they improve keyboard support (and customization of keyboard shortcuts) with Unity 8.

@lazka lazka closed this in c84f82c Feb 11, 2016

lazka added a commit that referenced this issue Feb 11, 2016

Merge pull request #1818 from qwence/master
Fix #1726: Enable accels for ViewSearchBar etc.
@spxxxk

This comment has been minimized.

spxxxk commented Jul 23, 2016

Broke again since last update.

(Not sure if I should open a new issue)

@lazka

This comment has been minimized.

Member

lazka commented Jul 23, 2016

Seems to work here. Which update are you referring to?

btw, what would you think about setting them to "ctrl+1/2/3/.." be default?

@spxxxk

This comment has been minimized.

spxxxk commented Jul 23, 2016

Not sure it's the last update actually, maybe I used the same browser for a while.. But since the menus changed I thought it could be related.
QL version : 3.6.99+8220~02e672a-0~ppa0~xenial

Like before, the default accels file no longer includes view actions.

Ctrl+1/2... could work, although there are already 9 browsers.

lazka added a commit that referenced this issue Jul 23, 2016

@lazka

This comment has been minimized.

Member

lazka commented Jul 23, 2016

It got renamed to Browse instead of view, renamed it back now and pushed to the ppa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment