New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize to tray on Plasma5 (KDE) #1756

Open
ochurlaud opened this Issue Dec 4, 2015 · 28 comments

Comments

Projects
None yet
4 participants
@ochurlaud

ochurlaud commented Dec 4, 2015

Is there an option or a plugin to install to minimize to tray?

I'm using Plasma5 on Archlinux and when I quit QuodLibet, it quits for real...

Thx

@urielz

This comment has been minimized.

Contributor

urielz commented Dec 4, 2015

Go to "Music", then "Plugins" and activate "Tray Icon", that should do it.

@ochurlaud

This comment has been minimized.

ochurlaud commented Dec 4, 2015

Ok, the problem is that KDE doesn't show it in the tray bar...

@lazka

This comment has been minimized.

Member

lazka commented Dec 5, 2015

Afaik plasma5 no longer supports tray icons. Might be related: #1343

@ochurlaud

This comment has been minimized.

ochurlaud commented Dec 8, 2015

It does support, but it follows this spec: http://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/ which is (as I understood) the right one...

@lazka

This comment has been minimized.

Member

lazka commented Dec 8, 2015

We don't support that atm (I didn't know that that was used outside of Ubuntu where mpris + the unity task bar integration is usually enough..)

See https://lazka.github.io/pgi-docs/#AppIndicator3-0.1

@lazka lazka added the enhancement label Dec 8, 2015

@ochurlaud

This comment has been minimized.

ochurlaud commented Dec 8, 2015

Is it what is used?

@lazka

This comment has been minimized.

Member

lazka commented Dec 8, 2015

Is it what is used?

What are you referring to?

On Linux there are four things for exposing a menu of some sorts:

  1. The old tray icon spec, which is X11 only, deprecated in most toolkits but still in use by things like Skype/VLC/dropbox etc. We do support that atm.
  2. Ubuntu Unity provides an API for exposing a menu in the left taskbar. We support that atm.
  3. Then there is MPRIS1/2 which some DEs use to build a mediaplayer widget (Ubuntu for example, or when using GNOME with an MPRIS extension). We do support that.
  4. And then there is the spec you mentioned which we currently don't support, but I guess we should if KDE moved to it.
@ochurlaud

This comment has been minimized.

ochurlaud commented Dec 8, 2015

Ok. I think KDE was using what you put in 1). But they movedto 4) and 3).

I was asking if your link (api) is what you currently use.

@lazka

This comment has been minimized.

Member

lazka commented Dec 8, 2015

Ok. I think KDE was using what you put in 1). But they movedto 4) and 3).

Possible. I remember that early Ubuntu versions only used MPRIS if (4) was implemented.. maybe that's the case here too

I was asking if your link (api) is what you currently use.

This is the Python API for implementing https://wiki.freedesktop.org/www/Specifications/StatusNotifierItem/ (If I'm not mistaken..)

@ochurlaud

This comment has been minimized.

ochurlaud commented Dec 8, 2015

So it means that it's almost solved isn't it?

@ArchangeGabriel

This comment has been minimized.

ArchangeGabriel commented Dec 8, 2015

Note that Plasma 5.5, which came out today, has a new change related to this:

In response to feedback, we've rewritten support for legacy applications not using the StatusNotifier standard for system tray icons.

(From https://dot.kde.org/2015/12/08/plasma-55-beautiful-new-artwork)

@ochurlaud

This comment has been minimized.

ochurlaud commented Dec 9, 2015

Yes I saw that too... Nevertheless they reimplement the 1) on lazka's list which is old and deprecated, so going to the new things (4) seems needed.

@lazka

This comment has been minimized.

Member

lazka commented Dec 9, 2015

Note that Plasma 5.5, which came out today, has a new change related to this:

In response to feedback, we've rewritten support for legacy applications not using the StatusNotifier standard for system tray icons.

(From https://dot.kde.org/2015/12/08/plasma-55-beautiful-new-artwork)

Thanks for the info.

Yes I saw that too... Nevertheless they reimplement the 1) on lazka's list which is old and deprecated, so going to the new things (4) seems needed.

Agreed, especially as (1) doesn't work with Wayland.

lazka added a commit that referenced this issue Dec 14, 2015

trayicon: basic appindicator support. See #1756
Split things up; The appindicator needs a persistant menu
so try to make the existing menu code dynamic (player repead/orders missing)
and use it for both implementations.

Atm the indicator will be used under Unity and Wayland.
@lazka

This comment has been minimized.

Member

lazka commented Dec 14, 2015

Basics are working now with master. But you need libappindicator-gtk3 (afaics this in only in AUR)

@ochurlaud

This comment has been minimized.

ochurlaud commented Dec 14, 2015

I've got it. I'll check this. Thx a lot.

@lazka

This comment has been minimized.

Member

lazka commented Dec 19, 2015

Things should work now in master, so I'm closing this. If there are any problems please report them here or in a new issue.

@lazka lazka closed this Dec 19, 2015

@ochurlaud

This comment has been minimized.

ochurlaud commented Feb 2, 2016

@lazka: is this patched in 3.5.3? thx

@lazka

This comment has been minimized.

Member

lazka commented Feb 2, 2016

No, but as pointed out in #1756 (comment) the old tray icon should work again if you update to plasma 5.5.

This will be part of 3.6

I guess we should look into providing an unstable build for the AUR..

@lazka

This comment has been minimized.

Member

lazka commented Feb 2, 2016

See #1805

@ochurlaud

This comment has been minimized.

ochurlaud commented Feb 2, 2016

I can write one if you want.... With the upgrade of plasma 5.5 it doesn't really work. You have an icon, but most of the time black, never scaled.

@ochurlaud

This comment has been minimized.

ochurlaud commented Feb 2, 2016

From master branch:

  • As you can see it's not perfect... http://postimg.org/image/56dhc05x5/
    Sometimes (not often) the icon is ok.
  • Clicking on it never reopens quodlibet (or doesn't do anything at all).

@lazka I don't find the "Reopen" button.

@lazka lazka reopened this Feb 7, 2016

@lazka

This comment has been minimized.

Member

lazka commented Feb 7, 2016

What's your output for python2 -Wignore -c "from gi.repository import AppIndicator3"

@ochurlaud

This comment has been minimized.

ochurlaud commented Feb 7, 2016

@lazka

This comment has been minimized.

Member

lazka commented Feb 8, 2016

Weird.. Do you see the "Show Quod Libet" menu item on top of the menu?

Here is how it looks on an uptodate arch (plasma 5.5.4). I've installed quodlibet-git and libappindicator-gtk3 through yaourt

screen

@ochurlaud

This comment has been minimized.

ochurlaud commented Feb 8, 2016

Ok... I'm on plasma 5.5.4 as well, libappindicator-gtk3 as well but it's still the same : weird icon, no interaction with the icon (no menu either)....

Don't know why... I'll try to check if I'm missing something. Are you using the Tray Icon plugin?

Very strange.

@ochurlaud

This comment has been minimized.

ochurlaud commented Feb 8, 2016

I just completely uninstall quodlibet and check the config of plasma.. Still the same.
Next try: in virtualbox.

@ochurlaud

This comment has been minimized.

ochurlaud commented Feb 8, 2016

D: 249.60: fake.plugins.trayicon.get_indicator_impl: use app indicator: False

XDG_SESSION_DESKTOP is set with KDE. but you check plasma.
--- This might be the problem?
I asked on IRC, KDE is the expected value... Any idea?

@lazka

This comment has been minimized.

Member

lazka commented Feb 8, 2016

hm, It's plasma here.. maybe because I use gdm3, I'll have a look

(That's why I asked about the "Show Quod Libet" item, which is only there if AppIndicator3 is used..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment