Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a two-state play/pause icon #1814

Closed
timpulver opened this issue Feb 9, 2016 · 13 comments
Closed

Use a two-state play/pause icon #1814

timpulver opened this issue Feb 9, 2016 · 13 comments

Comments

@timpulver
Copy link

@timpulver timpulver commented Feb 9, 2016

When player is playing the icon of the button should switch to a pause icon.

@kaffeeundsalz
Copy link

@kaffeeundsalz kaffeeundsalz commented Feb 9, 2016

Please don't. This will open the door to confusing people because a common standard is missing for one of the fundamental UI issues: Will a button show the current state of its function, or will it show the action to be performed when the button is used? This is a mess across different applications, and the only solution to avoid this is to do without changing button icons altogether. I'm very happy with the pressed/not pressed button state QuodLibet uses now; after all, this is a UI standard. Please don't change this.

@timpulver
Copy link
Author

@timpulver timpulver commented Feb 9, 2016

Check every other music player around. The current behavior is not standard!

@kaffeeundsalz
Copy link

@kaffeeundsalz kaffeeundsalz commented Feb 9, 2016

Yes – I know how other players do it. And I hate it ;) That's why I actually use the progress bar on my iPhone to be sure about the current playing status. No offense; I was thinking that I'm not the only one with this problem. If everybody else thinks this is a good idea, go implement it :)

@timpulver
Copy link
Author

@timpulver timpulver commented Feb 9, 2016

I understand what you mean. I just think it’s in general a good idea to stick to the stuff people know and expect if it’s not too bad.

@lazka
Copy link
Member

@lazka lazka commented Feb 10, 2016

play/pause:

  • more in line with other players
  • less interface noise without a pressed button

toggle-play:

  • imo easier to see the state (but this could be because I'm used to it)
  • users are used to it

not sure..

@timpulver
Copy link
Author

@timpulver timpulver commented Feb 10, 2016

I’m sure it’s a bit confusing for most people switching over from other players to not have play/pause.

@declension
Copy link
Member

@declension declension commented Feb 10, 2016

I can see both arguments, but actually am marginally in favour of changing (i.e. to play/pause), or at least more prominent highlighting (theme dependent, I know).

Users being used to it is an issue; if it's bad enough we could make it a preference...

@urielz
Copy link
Contributor

@urielz urielz commented Feb 11, 2016

I could be persuaded either way. Both methods have their advantages. To add one more thing:

Right now the play icon (the little icon to the left of the song currently playing) changes to the pause icon when the song is paused. In this respect it would be more visually consistent to also change the main play icon to the pause icon as the OP suggested...

@CreamyCookie
Copy link
Collaborator

@CreamyCookie CreamyCookie commented Feb 14, 2016

We could make it configurable. Similar to how one can change the symbols used for rating (e.g. rating_symbol_blank), there could be a play_symbol and a pause_symbol option in the config file.

For those who like the current version, the config would include:

play_symbol = ⏯
pause_symbol = ⏯

For those who want it to change, the config would be:

play_symbol = ▶️
pause_symbol = ⏸

Of course, we still do have to decide what becomes the default. 😜
I think I would try if I like the latter, so I would vote for that. But I agree with @urielz in that they both have their up- and downsides.

@declension declension changed the title [UI] Play-Pause Icon Use a two-state play/pause icon Feb 15, 2016
@declension declension added the UI label Feb 15, 2016
lazka added a commit that referenced this issue Feb 18, 2016
@lazka
Copy link
Member

@lazka lazka commented Feb 18, 2016

I've changed it in master now.. let's give it a try...

@declension
Copy link
Member

@declension declension commented Feb 18, 2016

Great! Like it a lot on first usage..

@CreamyCookie
Copy link
Collaborator

@CreamyCookie CreamyCookie commented Feb 18, 2016

Yeah, I agree. It feels better.

@lazka
Copy link
Member

@lazka lazka commented Feb 18, 2016

Ok, lets close this then - sorry @kaffeeundsalz :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants