New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default theme —> Dark #1864

Closed
timpulver opened this Issue Feb 29, 2016 · 10 comments

Comments

Projects
None yet
5 participants
@timpulver

timpulver commented Feb 29, 2016

I think the dark theme looks much better than the bright one. Maybe we could make it the default one!?
What do you guys think?

Also I would vote to set Show album cover with rounded corners to false per default.

@lazka lazka added the discussion label Feb 29, 2016

@lazka

This comment has been minimized.

Member

lazka commented Feb 29, 2016

I prefer the other option in both cases :)

@declension

This comment has been minimized.

Member

declension commented Feb 29, 2016

Me too...

@timpulver

This comment has been minimized.

timpulver commented Feb 29, 2016

Okay, worth a try… :)

@timpulver timpulver closed this Feb 29, 2016

@lazka

This comment has been minimized.

Member

lazka commented Mar 2, 2016

somewhat related, what about we use the border radius of buttons in the theme and get rid of the option?

@declension

This comment has been minimized.

Member

declension commented Mar 2, 2016

+1

@timpulver

This comment has been minimized.

timpulver commented Mar 2, 2016

I dislike rounded corners, but I agree, I don’t think something like this belongs in the UI.

lazka added a commit that referenced this issue Mar 2, 2016

Remove rounded cover preference and make border radius depend on them…
…e. See #1864

Use the radius from MAX(GtkEntry, GtkButton)
@lazka

This comment has been minimized.

Member

lazka commented Mar 2, 2016

They are now half the radius as before using Adwaita.. so it's somewhat of a compromise :)

@janc13

This comment has been minimized.

janc13 commented Apr 2, 2016

So now I get big ugly rounded corners on all my album art when I use QuodLibet on Ubuntu with Unity... :-(

I personally think it's wrong to use the border radius of buttons for something that isn't a button. In fact, I think that adding rounded corners to album art is wrong because album art is usually rectangular by nature, and sometimes contains "essential" details in the corners. (But that's my personal opinion, I guess.)

If some people like it then of course I'm not against it being an option, and I don't really care too much about what the default is either... :)

@timpulver

This comment has been minimized.

timpulver commented Apr 3, 2016

In fact, I think that adding rounded corners to album art is wrong because album art is usually rectangular by nature, and sometimes contains "essential" details in the corners.

I totally agree. Cover-designers have a rectangular area to work with, if you cut off the corners, you are altering how it looks.

@kmf

This comment has been minimized.

kmf commented Jun 12, 2016

The rounded corners for Album art on Ubuntu look lame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment