New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertionError when I add a custom browser #1919

Closed
SnouF opened this Issue Apr 17, 2016 · 7 comments

Comments

Projects
None yet
2 participants
@SnouF

SnouF commented Apr 17, 2016

When I add my custom browser in ~/.quodlibet/browsers I have a AssertionError

Traceback (most recent call last):
  File "/usr/bin/quodlibet", line 231, in <module>
    main(util.argv)
  File "/usr/bin/quodlibet", line 79, in main
    browsers.init()
  File "/usr/lib/python2.7/dist-packages/quodlibet/browsers/__init__.py", line 47, in init
    load_compiled=load_pyc)
  File "/usr/lib/python2.7/dist-packages/quodlibet/util/importhelper.py", line 24, in load_dir_modules
    assert package in sys.modules
AssertionError

If I remove ("/usr/lib/python2.7/dist-packages/quodlibet/util/importhelper.py", line 24)

assert package in sys.modules

my browser work (it use cpickle)

Quod Libet 3.6.1 with officiel debian package quodlibet:all/sid 3.6.1-2

@lazka

This comment has been minimized.

Member

lazka commented Apr 17, 2016

Indeed, seems like this is broken since at least 3.2 based on quick testing. The interface for browsers in ~/.quodlibet/browsers was changing quite often anyway and developing works just as well by placing it into the source tree, so I'm going to remove that "feature".

@lazka lazka closed this in 12bff95 Apr 17, 2016

@lazka

This comment has been minimized.

Member

lazka commented Apr 17, 2016

@SnouF

This comment has been minimized.

SnouF commented Apr 17, 2016

I regret this feature to be suppressed. But this choice seems justified;)

@lazka

This comment has been minimized.

Member

lazka commented Apr 17, 2016

I regret this feature to be suppressed.

Why? Just wondering...

@SnouF

This comment has been minimized.

SnouF commented Apr 19, 2016

Can add a browser by copy paste without root permission is easy and convenient. Especially for users

@lazka

This comment has been minimized.

Member

lazka commented Apr 20, 2016

OK, thanks. Maybe we'll add browser plugins in the future..

@SnouF

This comment has been minimized.

SnouF commented Apr 21, 2016

Will be perfect !

I did not have long used the Quodlibet podcatcher did not suit me caril there was no "filter" listen / not listen.
This feature is still no but my little python knowledge allowed me to adapt audiofeed https://gitlab.com/snouf/quodlibet_podcasts_browser

Iam happy to see that the project is still very active.

Tank for your job !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment