New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome Shell: No tray icon #1999

Closed
sebadorn opened this Issue Jul 29, 2016 · 11 comments

Comments

Projects
None yet
2 participants
@sebadorn

sebadorn commented Jul 29, 2016

I upgraded today from Ubuntu 14.04.4 to 16.04.1. After that Quod Libet's tray icon wasn't visible, but still interactable. Only the tray icon is affected, all other icons (application menu etc.) show just fine.

Some general info:
Quod Libet 3.6.2, Gnome Shell 3.18.5 with TopIcons extensions, Numix icon theme (but changing the icon theme didn't solve the problem).


After some digging, I found that quodlibet.app.symbolic_icon_name() in quodlibet.appindicator returned "None-symbolic", because quodlibet.app.id is not set (same with quodlibet.app.name). So I changed the ID to 'quodlibet'.

Still didn't show the icon. So I probably have to add a "quodlibet-symbolic" icon to the theme, but I just changed symbolic_icon_name() to omit the "-symbolic" part and now it works:

working_ql_tray_icon


Btw: I love how fast indexing and searching are in Quod Libet and the tagging + renaming options of Ex Falso. Great job!

@lazka

This comment has been minimized.

Member

lazka commented Jul 29, 2016

hm, could it be that only the "exfalso" package is up to date, but not the "quodlibet" package?

@sebadorn

This comment has been minimized.

sebadorn commented Jul 29, 2016

If it is relevant: I use the PPA http://ppa.launchpad.net/lazka/ppa/ubuntu to keep Quod Libet up-to-date.

@lazka

This comment has been minimized.

Member

lazka commented Jul 29, 2016

ok. another weird thing is that appindicator should only be used when running under unity, not gnome.

I'll try installing gnome under 16.04

@lazka lazka added the bug label Jul 29, 2016

@lazka

This comment has been minimized.

Member

lazka commented Jul 29, 2016

Are you using lightdm (ubuntu login screen) or gdm3 (gnome login screen)?

@sebadorn

This comment has been minimized.

sebadorn commented Jul 29, 2016

lightdm.

quodlibet.util.is_unity() returns True for me. Maybe because I also have Unity installed, though I'm using Gnome Shell?

@lazka

This comment has been minimized.

Member

lazka commented Jul 29, 2016

It detects if unity is running not if it's installed.

Do you use default ubuntu or gnome ubuntu etc..?

@sebadorn

This comment has been minimized.

sebadorn commented Jul 29, 2016

The "normal" Ubuntu. I think since 12.04 I only used upgrades, never a fresh install. At some point I installed gnome-shell.

@lazka

This comment has been minimized.

Member

lazka commented Jul 30, 2016

I can't reproduce with an updated 16.04 + gnome + lightdm. No idea how else we can detect if unity is running. Maybe check for "com.canonical.Unity.Launcher" as well?

And the unset app.id is a different problem which I don't know how it can happen (It gets set in /usr/bin/quodlibet)

@sebadorn

This comment has been minimized.

sebadorn commented Jul 30, 2016

Oh, my mistake, sorry. app.id is set. It wasn't because I did my testing in a Python console and just did an import quodlibet. When properly starting /usr/bin/quodlibet it is set.

I changed my workaround now to have is_unity() check for com.canonical.Unity.Launcher which returns False in my case and added the "-symbolic" back in. The tray icon is still working.

Checking for com.canonical.Unity returns True, but com.canonical.Unity.Launcher returns False. Here is my (shortened) result for bus.list_names():

com.canonical.Unity
com.canonical.Unity.WindowStack
com.canonical.URLDispatcher
com.ubuntu.Upstart
org.cairodock.CairoDock
org.freedesktop.DBus
org.freedesktop.FileManager1
org.freedesktop.IBus
org.freedesktop.Notifications
org.freedesktop.ScreenSaver
org.freedesktop.secrets
org.freedesktop.Telepathy.*
org.gnome.Caribou.Keyboard
org.gnome.evolution.dataserver.*
org.gnome.GConf
org.gnome.Identity
org.gnome.keyring
org.gnome.keyring.SystemPrompter
org.gnome.Magnifier
org.gnome.Mutter.DisplayConfig
org.gnome.Mutter.IdleMonitor
org.gnome.Nautilus
org.gnome.OnlineAccounts
org.gnome.Panel
org.gnome.ScreenSaver
org.gnome.SessionManager
org.gnome.SettingsDaemon
org.gnome.Shell
org.gnome.Shell.CalendarServer
org.gnome.Shell.Screencast
org.gnome.Shell.Screenshot
org.gnome.Software
@lazka

This comment has been minimized.

Member

lazka commented Jul 30, 2016

Thanks for debugging.

lazka added a commit that referenced this issue Jul 30, 2016

unity: check for com.canonical.Unity.Launcher instead of com.canonica…
…l.Unity. See #1999

The former can apparently be active under GNOME as well.
@lazka

This comment has been minimized.

Member

lazka commented Jul 30, 2016

Regarding the icon: We don't want to use the indicator anyway under GNOME, so it doesn't matter if it is broken there. Also gnome has no official app indicator implementation, there is just this unmaintained extension: https://extensions.gnome.org/extension/615/appindicator-support/

Will be available in the next release or in the unstable PPA right now.

@lazka lazka closed this Jul 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment