New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quodlibet hides automounted library #2146

Closed
nemoinis opened this Issue Dec 12, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@nemoinis

nemoinis commented Dec 12, 2016

Hello,
I'm running quodlibet 3.7 on Debian testing (Stretch right now).
My music library is a NFS mount managed by automount (autofs) so it gets mounted automatically on first access if not already, and is unmounted after a while when not in use.

The problem I have is that when first launched, quodlibet "hides" the library (I think this was the fix for bug #984) because it thinks it's not mounted. That's because the python os.path.ismount() call used by quodlibet, does not trigger an autofs mount.

I worked around that by using a little script that "test -e /path/to/music/." before launching quodlibet (that's enough to trigger the automount). But I think maybe quodlibet "jumps the gun" a little by assuming that an unmounted mountpoint means the music is not available. Maybe it should actually try to access it.

cheers!

@lazka

This comment has been minimized.

Member

lazka commented Dec 13, 2016

What does "access" mean in this case? ismount calls stat, just like "test -e".

@lazka lazka added the needinfo label Dec 13, 2016

@lazka

This comment has been minimized.

@nemoinis

This comment has been minimized.

nemoinis commented Dec 13, 2016

Hi lazka,
Thanks for the crystal-clear response. I think you missed the point, though.
Just assume my script does "test -e /path/to/music/crickets/chirping.mp3"

@lazka

This comment has been minimized.

Member

lazka commented Dec 13, 2016

ok, I assumed "/path/to/music/" is your mount point which confused me.

We should stat the first file we have for each mount point before calling ismount then.

@lazka lazka added enhancement and removed needinfo labels Dec 13, 2016

@lazka lazka closed this in b5bf982 Dec 13, 2016

@lazka

This comment has been minimized.

Member

lazka commented Dec 13, 2016

I hope that works, if not please reopen.

@nemoinis

This comment has been minimized.

nemoinis commented Dec 13, 2016

It works on my system. Thanks!

lazka added a commit that referenced this issue Dec 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment