New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create new playlists with selected files from context menu #2183

Closed
CreamyCookie opened this Issue Jan 6, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@CreamyCookie
Contributor

CreamyCookie commented Jan 6, 2017

When doing this

screenshot from 2017-01-06 12-10-33

an empty playlist file is created (it contains no songs), but no empty playlist appears in the playlist browser until restarting. Adding to an existing playlist does work.

Which version of Quod Libet?

3.8.0

Which operating system including version (Ubuntu 14.04, Win7, Debian sid, ...)?

Ubuntu 16.04

@declension

This comment has been minimized.

Member

declension commented Jan 6, 2017

Replicated. Thanks

@declension declension self-assigned this Jan 7, 2017

@declension declension closed this in 88261cf Jan 8, 2017

@CreamyCookie

This comment has been minimized.

Contributor

CreamyCookie commented Jan 8, 2017

Thanks for fixing!

lazka added a commit that referenced this issue Jan 12, 2017

Fix new playlists from menu, add tests. Closes #2183
 * Remove some static dependencies from `PlaylistMenu`
 * ...and use GTK+ signal to communicate a new playlist event to other objects
 * Extract interactive UI code (choosing new playlist name) to non-private methods, to allow stubbing in testing
 * Add some tests around this code, and a little around the indicator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment