New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soundcloud.library in song_by_track_id: KeyError: No track with id ... #2410

Closed
lazka opened this Issue May 31, 2017 · 3 comments

Comments

Projects
None yet
2 participants

@lazka lazka added bug sentry labels May 31, 2017

@lazka lazka added this to the 3.9.1 Release milestone May 31, 2017

@declension

This comment has been minimized.

Member

declension commented Jun 1, 2017

Hmm. I seem to recall this is one of those "shouldn't ever happen" problems (receiving comments about a song that is not there somehow), but clearly it does in some circumstances. Maybe an async thing, or could even be buggy data coming back.

Simple answer is just to put it to a print_w instead of an Exception I guess..

@lazka lazka closed this in 5d69d55 Jun 4, 2017

@lazka

This comment has been minimized.

Member

lazka commented Jun 4, 2017

Form what I see could be that the browser/library gets destroyed right at a song change. print_w seems fine.

@declension

This comment has been minimized.

Member

declension commented Jun 4, 2017

Thanks

lazka added a commit that referenced this issue Jun 6, 2017

soundcloud: ignore comments for songs we don't know. Fixes #2410
Not sure why we get them, but let's not crash.

@lazka lazka referenced this issue Dec 14, 2017

Closed

Error Occurred #2650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment