New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert lyrics window plugin to UI (sidebar) plugin #2553

Closed

declension opened this issue Sep 5, 2017 · 2 comments

Labels

enhancement plugins

Member

declension commented Sep 5, 2017

This plugin would probably be nicer as an sidebar, and we can do this now we have the plugin hooks.
See #273 (comment).

declension added enhancement plugins labels

Member Author

declension commented Sep 5, 2017

@lazka happy with that?

Member

lazka commented Sep 5, 2017

sure

declension added a commit that referenced this issue


          LyricsWindow: convert to sidebar (#2553)

eade6cd

 * Convert to `UserInterfacePlugin` with main UI class becoming a `ScrolledWindow` not a `Window`
 * Rename to `weblyrics` for clarity (but preserve existing config) and update description.
 * Remove x,y, w, h config options (no longer relevant)
 * Remove title-setting code

declension added a commit that referenced this issue


          LyricsWindow: convert to sidebar (#2553)

686a733

 * Convert to `UserInterfacePlugin` with main UI class becoming a `ScrolledWindow` not a `Window`
 * Rename to `weblyrics` for clarity (but preserve existing config) and update description.
 * Remove x,y, w, h config options (no longer relevant)
 * Remove title-setting code

declension closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment