New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
combining tag values uses a comma separator #2679
Comments
Thanks. I guess problem 2 is just #2678 |
I guess the ideal UX is that the editor somehow allows you to add multiple tags to the edited songs, i.e. giving the new songs two values "Adam Duritz (1964-)" and "Matt Malley", or neither, or either one of the two. It's multiple values from multiple songs being a problem here. Keeping the newline (an implementation detail, IMO) would probably solve the problem, but still looks weird seeing these "multiple" values suddenly in a single input box... |
Yes, problem 2 is mostly #2678 but I got forced into the issue because of the bad separator choice. However, if there are commas in the separate values then the situation would be worse here. What I think should happen is that the multiple values stay with the internal (newline) separator and not use the comma (or any other in-line separator). This should happen everywhere possible and not just in this case. (Of course there may not be any other cases - I haven't found any yet anyway.) |
It looks as if it is possible to fix the problem by simply not replacing newline with comma in __edit_tag |
Here is the complicated setup.
I'm editing tags on two tracks. One track has a tag with two values - "Adam
Duritz (1964-)" and "Matt Malley". The other track has no values for that
tag.
I see the two values for the tag, separated, each with "(missing from 1
song)". I click on the tag area and then on the values. I then see the two
values merged together with the Unicode newline glyph between them. I then
click elsewhere and the two values are melded together with a comma between
them.
Problem 1:
I can't split the values apart because I only use semicolon as my separator
character and the separator introduced was a comma.
Problem 2:
Even if I add comma back into my separators I can't split the values apart
because the first "value" ends with a non-word character.
I suggest that this combination isn't done by introducing a comma separator
but instead keeps the newline if possible.
The text was updated successfully, but these errors were encountered: