New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SerializationError #2719

Closed
lazka opened this Issue Jan 12, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@lazka
Member

lazka commented Jan 12, 2018

https://sentry.io/quodlibet/quodlibet/issues/433099520/

MemoryError: 
  File "quodlibet/util/picklehelper.py", line 41, in pickle_dumps
    return pickle.dumps(obj, protocol)

PicklingError: 
  File "quodlibet/formats/_serialize.py", line 214, in dump_audio_files
    return pickle_dumps(item_list, 2)
  File "quodlibet/util/picklehelper.py", line 45, in pickle_dumps
    raise PicklingError(e)

SerializationError: 
  File "quodlibet/util/copool.py", line 26, in wrap
    for value in func(*args, **kwargs):
  File "quodlibet/_main.py", line 376, in periodic_library_save
    quodlibet.library.save(save_period=15 * 60)
  File "quodlibet/library/__init__.py", line 56, in save
    lib.save()
  File "quodlibet/library/libraries.py", line 273, in save
    fileobj.write(dump_audio_files(self.get_content()))
  File "quodlibet/formats/_serialize.py", line 216, in dump_audio_files
    raise SerializationError(e)

SerializationError
@lazka

This comment has been minimized.

Member

lazka commented Jan 12, 2018

Not much info there. Maybe it's failing because we modify the objects being pickled and we should just ignore when that fails in the cyclic save.

@lazka lazka added the sentry label Jan 12, 2018

@lazka lazka closed this in 050e31f Jan 13, 2018

@lazka lazka added this to the 4.0.1 milestone Jan 13, 2018

lazka added a commit that referenced this issue Jan 13, 2018

library: ignore SerializationError for now. Fixes #2719
When doing the periodic library save while the library is being modified
pickle fails. Ignore the error for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment