Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect song lengths #2758

Closed
billop opened this issue Feb 4, 2018 · 5 comments
Closed

Incorrect song lengths #2758

billop opened this issue Feb 4, 2018 · 5 comments

Comments

@billop
Copy link

@billop billop commented Feb 4, 2018

I'm running Arch Linux, with everything up to date, and the latest quodlibet built from github.

All the songs in the album Panic by Caravan Palace have insanely long lengths. Rescanning and rebuilding and whatnot isn't changing the lengths. And I know that they are not actually that long because ncmpcpp and clementine recognize their true lengths and also, if I try to seek ahead to for example, 1 hour into a song, quodlibet will immediately skip to the next song.

screenshot_20180204_001914

@lazka
Copy link
Member

@lazka lazka commented Feb 4, 2018

Can you send me one of those files? -> reiter.christoph@gmail.com

@lazka
Copy link
Member

@lazka lazka commented Feb 4, 2018

Thank. This is https://quodlibet.readthedocs.io/en/latest/guide/faq.html?highlight=tlen#why-do-my-mp3-files-have-the-wrong-length

We have a "Fix MP3 duration" plugin, but I see that is broken for some reason.. :/

@lazka
Copy link
Member

@lazka lazka commented Feb 4, 2018

I think we should just remove TLEN support..

@billop
Copy link
Author

@billop billop commented Feb 4, 2018

Is there any benefit to having TLEN support? Because if ncmpcpp and clementine recognized the true lengths of the songs, it would imply that they didn't care about the TLEN frame right?

I removed the "Length" tag in kid3 from all the songs in the album and now quodlibet is displaying the correct lengths.

@lazka lazka closed this in 7bb1213 Feb 4, 2018
@lazka
Copy link
Member

@lazka lazka commented Feb 4, 2018

Is there any benefit to having TLEN support? Because if ncmpcpp and clementine recognized the true lengths of the songs, it would imply that they didn't care about the TLEN frame right?

I don't think so, no, I've removed it now. Might be that 10 years ago our MP3 parsing code wasn't that good and TLEN helped for the cases where it failed.

I removed the "Length" tag in kid3 from all the songs in the album and now quodlibet is displaying the correct lengths.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants