New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App menu doesn't work on Wayland #2846

Closed
fkrull opened this Issue May 16, 2018 · 11 comments

Comments

Projects
None yet
3 participants
@fkrull
Contributor

fkrull commented May 16, 2018

The application menu (the one you get when you click on the window title in gnome-shell) doesn't work on Wayland:

app-menu-wayland

This was with QL 4.0.2 on Ubuntu 18.04 with Wayland.

The code piece that registers the app menu only works on X11. The "proper" way to fix this would be to use GtkApplication and its set_app_menu method, but I suspect that requires some in-depth changes.

(This one isn't a Flatpak issue, I checked.)

@lazka

This comment has been minimized.

Member

lazka commented May 16, 2018

Yeah, thanks.

@lazka lazka added the wayland label May 17, 2018

@Valeryan24

This comment has been minimized.

Valeryan24 commented Jun 17, 2018

Hi, is it a similar problem (I don't want to create a duplicate issue) that makes Quod Libet icon not visible in Ubuntu dock with Wayland session on 18.04 / 18.10 (bottom of the screenshot) ?
https://framapic.org/U5PfilFgyGtS/0eNA4cqulf1Y.png
Thanks for your great work !

@lazka

This comment has been minimized.

Member

lazka commented Jun 17, 2018

@Valeryan24 how did you install QL?

@Valeryan24

This comment has been minimized.

Valeryan24 commented Jun 17, 2018

First with the default Ubuntu package (I use development version 18.10 on Wayland), then with your unstable ppa: both give the same result for dock and top bar icon.

@lazka

This comment has been minimized.

Member

lazka commented Jun 17, 2018

First with the default Ubuntu package (I use development version 18.10 on Wayland), then with your unstable ppa: both give the same result for dock and top bar icon.

Thanks, that's a bug then. Might be that us not using GtkApplication is the same cause, but please open a new issue for this. Thanks!

@lazka

This comment has been minimized.

Member

lazka commented Jun 24, 2018

Gnome is moving away from app menus now, so we can probably just get rid of it altogether.

@fkrull

This comment has been minimized.

Contributor

fkrull commented Jun 24, 2018

Wait, they are? Bloody hell, can't they make up their minds.

@lazka

This comment has been minimized.

Member

lazka commented Jun 24, 2018

https://wiki.gnome.org/Design/Whiteboards/AppMenuMigration (just a proposal, of one person, but I think many will agree)

I wont miss them at least.

@lazka

This comment has been minimized.

Member

lazka commented Jul 7, 2018

@lazka lazka closed this in 0d5fbc5 Jul 7, 2018

lazka added a commit that referenced this issue Jul 8, 2018

@lazka

This comment has been minimized.

Member

lazka commented Jul 8, 2018

I had to revert because tests started to fail without a clear error message.

@lazka lazka reopened this Jul 8, 2018

lazka added a commit that referenced this issue Aug 30, 2018

Remove GNOME app menu. Fixes #2846
GNOME is moving away from them and we only mirrored some actions
to it for the sake of consistency and not because we need it.
So just remove it.

@lazka lazka closed this in 06603a0 Aug 30, 2018

@lazka

This comment has been minimized.

Member

lazka commented Aug 30, 2018

Turned out to be a crash in glib's dconf code, worked around by 833eb49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment