New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App icon is incorrect under KDE Plasma Wayland session #2974

Closed
glaubersm opened this Issue Sep 19, 2018 · 9 comments

Comments

Projects
None yet
3 participants
@glaubersm

glaubersm commented Sep 19, 2018

Hi
I have Quod libet 4.1.0 on Arch Linux running KDE Plasma Wayland session.
Window decoration show the Wayland generic icon instead Quod libet icon.

quod libet

@frestr

This comment has been minimized.

Member

frestr commented Sep 19, 2018

This was probably fixed in 36ef24b. I guess you can either install quodlibet-git from AUR or apply the fix described in #2889 to see if it helps.

@glaubersm

This comment has been minimized.

glaubersm commented Sep 19, 2018

Hi frestr
I have just installed quodlibet-git. Bug persists.

@frestr

This comment has been minimized.

Member

frestr commented Sep 19, 2018

The old desktop file might still be installed. Could you verify that the installed desktop file contains the line StartupWMClass=quodlibet, with a lowercase q?

@glaubersm

This comment has been minimized.

glaubersm commented Sep 19, 2018

I have two desktop files:
~/.local/share/applications/io.github.quodlibet.QuodLibet.desktop
/usr/share/applications/io.github.quodlibet.QuodLibet.desktop

First desktop file had uppercase Q. I changed to q, restarted my session but the icon is still incorrect. Second desktop file already had lowercase q.

@frestr

This comment has been minimized.

Member

frestr commented Sep 19, 2018

Ok, thanks for checking. Seems to be a separate bug then.

@lazka

This comment has been minimized.

Member

lazka commented Sep 20, 2018

I remember some post on planet-gnome that the full app id needs to be passed to GLib.set_prgname which we don't do currently.

edit: https://honk.sigxcpu.org/con/GTK__and_the_application_id.html

lazka added a commit that referenced this issue Sep 20, 2018

wayland: fix the window app id. See #2974
The gtk wayland backend uses the string passed to g_set_prgname
for the app id.
@lazka

This comment has been minimized.

Member

lazka commented Sep 20, 2018

Might be fixed in master

@lazka lazka added the needinfo label Sep 20, 2018

@lazka

This comment has been minimized.

Member

lazka commented Sep 22, 2018

I've tested with KDE and it works now.

@lazka lazka closed this Sep 22, 2018

@glaubersm

This comment has been minimized.

glaubersm commented Sep 22, 2018

Thank you very much for the quick fix.
Have a nice day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment