New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With 4.2, can't add to MATE dock or Plank #3029

Closed
elcste opened this Issue Nov 3, 2018 · 10 comments

Comments

Projects
None yet
2 participants
@elcste
Copy link

elcste commented Nov 3, 2018

On Ubuntu MATE 18.10, I just upgraded from 4.1.0 (from the Ubuntu archive) to 4.2.0 from the quodlibet-stable PPA. Now I cannot add Quod Libet to the MATE Dock Applet dock. When I launch 4.2, it opened as a second app icon, and this icon is missing the "pin" option that other apps have. If I unpin the first icon, I still can't pin the second one.

Similarly, when I tried Plank, QL doesn't have the "keep in dock" option.

When I downgrade to the 4.1.0-1 package, it works normally again.

I don't have a custom .desktop file or anything else I know of that should effect this. Just to be safe, I tried a new user account and saw the same behavior.

FWIW I believe both of these docks use bamfdaemon for app matching.

@lazka

This comment has been minimized.

Copy link
Member

lazka commented Nov 3, 2018

Thanks.

@lazka lazka added the bug label Nov 3, 2018

@lazka

This comment has been minimized.

Copy link
Member

lazka commented Nov 8, 2018

The only related change that comes to mind is 175d21b but not sure how/why :)

If someone has the same problem with another dock (that is more common and easier to install) please add some info here.

@elcste

This comment has been minimized.

Copy link

elcste commented Nov 8, 2018

Fair enough, thanks for looking at it.

I think more people use Plank, and I think Unity also used banfdemon, so maybe someone who's still on 16.04 can take a look.

@lazka

This comment has been minimized.

Copy link
Member

lazka commented Nov 9, 2018

Thanks, 16.04 shows the same problem.

@elcste

This comment has been minimized.

Copy link

elcste commented Nov 17, 2018

I submitted a bug for bamf, since maybe it's their issue if no one has had a problem using other systems, like GNOME Shell.

@lazka

This comment has been minimized.

Copy link
Member

lazka commented Nov 17, 2018

@elcste thanks!

@elcste

This comment has been minimized.

Copy link

elcste commented Nov 17, 2018

A banf developer did not think it's their bug. I was hoping for something obvious they'd see ;-) They suggested looking in the syslog, but I don't see anything related to banf, just some gtk theme warnings.

I did notice one thing, however. With 4.1, the MATE Dock and Plank list Quod Libet as "Quod Libet" in the menu/tooltip. With 4.2, it is listed as " - Quod Libet". It looks like the actual window is called " - Quod Libet" in both cases. (I think I didn't see this before because it doesn't show up this way in the MATE Dock when I click the icon of QL I had pinned with 4.1, but it show up this way if I launch it from the terminal. With Plank, it shows up this way either way.)

MATE Dock menu with Quod Libet 4.1
dock 4 1

MATE Dock menu with Quod Libet 4.2 (The top icon is one I had pinned with 4.1, the botom appears when I launch Quod Libet.)
dock 4 2

Plank tooltip with Quod Libet 4.1
plank 4 1

Plank tooltip with Quod Libet 4.2 (The left icon is one I had pinned with 4.1, the right appears when I launch Quod Libet.)
plank 4 2

@lazka

This comment has been minimized.

Copy link
Member

lazka commented Nov 17, 2018

bisected to 175d21b

@lazka lazka closed this in 5a1ecc1 Nov 17, 2018

lazka added a commit that referenced this issue Nov 18, 2018

desktop file: make StartupWMClass match the name we set with GLib.set…
…_prgname. Fixes #3029

gtk uses it to set WM_CLASS under X11 and this has to match StartupWMClass
in the desktop file.
@elcste

This comment has been minimized.

Copy link

elcste commented Dec 1, 2018

I went on vacation right before that commit, so I just now confirmed it is fixed for me too with the version from your unstable PPA.

Do you accept donations somewhere so I can buy you a coffee/beer?

@lazka

This comment has been minimized.

Copy link
Member

lazka commented Dec 3, 2018

Thanks for testing!

(I only have an idle patreon account, but no need to..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment