New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search all songs in an album for embedded album art #924

Closed
lazka opened this Issue Mar 14, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@lazka
Member

lazka commented Mar 14, 2015

Original issue 924 created by reiter.christoph on 2012-02-28T09:41:01.000Z:

https://bugs.launchpad.net/ubuntu/+source/quodlibet/+bug/930808

@lazka

This comment has been minimized.

Member

lazka commented Mar 14, 2015

Comment #1 originally posted by nick.boultbee on 2012-02-28T19:12:23.000Z:

Getting this right would be nice, but also pose some difficulties:

  1. What definition of album are we using (hopefully not freetext match like Filter On.. - see the infamous Issue #659)
  2. How do we decide amongst multiple matches, e.g. songs in different directories that have their own folder.jpg? In addition to normal rules? Just find the first song that matches?..
  3. Caching of this information (Running the album art selection algorithm is quite intensive already, but doing it each time for 20 tracks or more could become a problem
@lazka

This comment has been minimized.

Member

lazka commented Mar 14, 2015

Comment #2 originally posted by reiter.christoph on 2012-02-28T20:33:38.000Z:

  1. The Album object
  2. Yeah, first song is enough, for the not embedded case I'd even say only in album.list("~dirname"), since most of the cover selection algo is part of the album key (in favor of performance)
  3. For the not embedded case it's only once in the common case if we use ~dirname, for embedded case it is saved in ~picture, so also once.
@lazka

This comment has been minimized.

Member

lazka commented Mar 14, 2015

Comment #3 originally posted by reiter.christoph on 2014-08-15T10:55:02.000Z:

This issue was closed by revision 41b2ef3.

@lazka lazka closed this Mar 14, 2015

lazka added a commit that referenced this issue Apr 8, 2015

Consider all songs in a album for finding album art. Closes issue #924.
For each cover source group songs and search for each group.
Try to return the same cover for the same set of songs every time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment