Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to enable/disable rating hotkeys. #1625

Merged
merged 2 commits into from Jul 25, 2015

Conversation

@ZDBioHazard
Copy link
Contributor

@ZDBioHazard ZDBioHazard commented May 30, 2015

This is sort-of a continuation of #1401.

Changing the hotkeys to <ctrl>-[0-x] nearly eliminated mis-ratings for me, but now I have another app that uses <ctrl>-[0-9] in it's UI, so I updated this patch just to be safe. 馃槈

@ZDBioHazard ZDBioHazard force-pushed the ZDBioHazard:rating-hotkeys-toggle branch from 5d84b10 to 0d562a9 May 30, 2015
@lazka
Copy link
Member

@lazka lazka commented May 30, 2015

Would you be OK with it not getting exposed in the UI and only in the config file?

@ZDBioHazard
Copy link
Contributor Author

@ZDBioHazard ZDBioHazard commented May 30, 2015

Works for me, though I just had a thought that I don't think the rating hotkeys are mentioned anywhere in-UI, so the option being present in the preferences dialog might clue users in that rating hotkeys are a thing they can use.

lazka added a commit that referenced this pull request Jul 25, 2015
Add a setting to enable/disable rating hotkeys.
@lazka lazka merged commit 0a1bb64 into quodlibet:master Jul 25, 2015
@ZDBioHazard ZDBioHazard deleted the ZDBioHazard:rating-hotkeys-toggle branch Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants