Add new events plugin - Synchronized Lyrics #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return vb | ||
|
|
||
| def getTextColor(self): | ||
| v = config.get("plugins", self.PLUGIN_ID + "_txt", |
There was a problem hiding this comment.
There's actually a class to wrap all this (consistently).
See PluginConfigMixin.
|
Thanks. It looks good to me, other than a few tweaks. Can we ensure adherence to PEP 8 naming - notably underscores for method names, not camel case. |
|
Thanks for the comments. I've followed PEP 8 conventions and used PluginConfigMixin. I'm not sure I understand the comment about depending on falsey things. That area of the code will act on strings such as |
declension
added a commit
that referenced
this pull request
Oct 27, 2015
Add new events plugin - Synchronized Lyrics
|
Great - thanks for the plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin reads .lrc files and shows timed lyrics.