Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication for MPDServer plugin #1789

Merged
merged 6 commits into from Jan 19, 2016
Merged

Conversation

@mistotebe
Copy link
Contributor

@mistotebe mistotebe commented Jan 16, 2016

MPD supports (plaintext) authentication using the "password" command. This is a minimal implementation that just supports a single all-powerful password.

@mistotebe mistotebe force-pushed the mistotebe:mpd_auth branch from 760767c to 97e2e7d Jan 16, 2016
@lazka
Copy link
Member

@lazka lazka commented Jan 18, 2016

Looks good. Please make sure the tests still work, e.g. ./setup.py test --to-run=TMPDCommands

@mistotebe mistotebe force-pushed the mistotebe:mpd_auth branch from 510db4b to 127fa8e Jan 19, 2016
@mistotebe
Copy link
Contributor Author

@mistotebe mistotebe commented Jan 19, 2016

Don't understand how the tests for this module really work, so I haven't set it up to test passwords yet.

lazka added a commit that referenced this pull request Jan 19, 2016
Add authentication for MPDServer plugin
@lazka lazka merged commit 7f652ff into quodlibet:master Jan 19, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants