Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
use sort tags in paned browser; union tied tags in paned browser #1796
1/ list_separate and list_sort (new) in quodlibet/formats/_audio.py
a) Union all results for tied tags instead of concatenating them in list_separate. (This is
b) Return display,sort pairs when a tag has an associated sort key with
2/ list_separate and format_list in quodlibet/pattern/_pattern.py
Handle display,sort pairs appropriately.
3/ paned browser
Use sort value for sorting if present.
1/ Paned browser uses sort tags when present.
1/ If a tag value has different sort values (including no sort value) in
Is the ball in my court? The last change I made was to always return pairs and ignore extra sort values, as requested. This didn't change any observable behaviour.
I have been running with the modification, with no problems. The effects of the changes are confined to the paned browser (unless add-ons can access this far down into quodlibet). I think that the changes are ready to go.
If the change is made, there probably should be some updates to the documentation. I'm willing to propose some updates. (How would this be done, by the way?)
The instance(..., tuple) checks in models.py are defensive. If a non-tuple
Some checks in format_list are needed. The output from a pattern execution
The special list_separate function inside the pattern function in
This seems to fail on Windows: https://travis-ci.org/quodlibet/quodlibet/jobs/109157054#L2479
The reason is running the results of format_list through _post. Should this be done for format_list at all?
OK, _post is on both display and sort, and all the required tests look good. I'm running the new patch locally and the results look fine. I have lots of songs with both sort values and without and the separating and sorting all looks correct even for complex patterns in the paned browser.