Improve lyrics-in-tags support (globally and for ID3 tags in particular) #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good if someone advised me how to do "detection" in the lyrics editor to save lyrics to file only if saving to tags is unsupported for this file. |
| @@ -357,6 +363,12 @@ def write(self): | |||
| tag.add(mutagen.id3.COMM(encoding=enc, text=t, desc=u"", | |||
| lang="\x00\x00\x00")) | |||
|
|
|||
| if "lyrics" in self: | |||
There was a problem hiding this comment.
Please add a test for reading/writing those frames in test_formats__id3.py
For now, explicitly seek for an USLT frame with empty content descriptor and zeroed language code (and write back the same frame).
|
@lazka: ping? |
lazka
added a commit
that referenced
this pull request
Feb 14, 2016
Improve lyrics-in-tags support (globally and for ID3 tags in particular)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lyricstag fromUSLTframe of ID3v2 tags(only empty desc and empty lang — others are ignored but not deleted)
~lyricsby looking both at the tags and the external file (in this order)~lyricsfor readinglyricstag and to the fileThis should fix #919.