New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duration format prefs #2021

Merged
merged 7 commits into from Aug 30, 2016

Conversation

Projects
None yet
2 participants
@declension
Member

declension commented Aug 29, 2016

Add configurable (by new preferences widget) display of durations around the app, notably in the Queue, the songlist (selection) info area (i.e. bottom right), and the Information window(s).

Fixes #1727, #1967.

declension added some commits Aug 29, 2016

Configurable duration (almost) everywhere
  * Add drop-down in prefs to select style ("format") of durations
  * Use extended enum for stronger typing of new config type
  * Make new time formatter which switchers between existing based on config
  * Use this in info window and in songlist summary widget (bottom right), etc
Duration format: add additional formats
 * two new formats, seconds (See #1967) and full (see #1727)
 * rename existing for sortability / sense
 * sort when displaying in prefs
Duration format: Improve refreshing
 * Move prefs section to its own frame within _Browser_ tab
 * ...and tidy that code a little
 * Define `refresh()` methods on queue and songlist UI elements
 * Call these explicitly (TODO: #2019) on prefs change.
Duration prefs: fix default value
...and add test to catch this.
@lazka

This comment has been minimized.

Member

lazka commented Aug 30, 2016

Looks good.

Some thoughts for future changes: To get rid of the option we could allow making the status label a editable pattern "<~tracks> (<~length>)" and introduce one more internal tag for seconds....

@declension declension merged commit baad7b5 into master Aug 30, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@declension declension deleted the duration-format-prefs branch Aug 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment