New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix covergrid preferences: slider release #2130

Merged
merged 3 commits into from Nov 30, 2016

Conversation

Projects
None yet
2 participants
@qwhex
Collaborator

qwhex commented Nov 29, 2016

The UI lagged as hell when I tried to change the cover magnification with the slider. Now it only updates the settings / redraws the covers when:

  • The user releases the slider
  • The new setting is different from the old one

qwhex added some commits Nov 29, 2016

Fix covergrid preferences: slider release
Only redraws the covers when the user releases the slider
@lazka

This comment has been minimized.

Member

lazka commented Nov 29, 2016

We have util.DeferredSignal for those situations.

How does mag_scale.connect('value-changed', util.DeferredSignal(mag_changed, owner=mag_scale)) perform?

Not using value-changed would break other things changing the slider, like the keyboard (or code)

@qwhex

This comment has been minimized.

Collaborator

qwhex commented Nov 29, 2016

You're right. I'm looking into DeferredSignal.

By the way my mouse wheel jumps 5.0...

Maybe an "Update" or a "Preview" button would be the best solution.

@qwhex

This comment has been minimized.

Collaborator

qwhex commented Nov 29, 2016

DeferredSignal behaves the same as the original one and lags heavily.

I introduced a mag_lock boolean to disable updating while sliding with the cursor.
Also fixed the mouse wheel problem (5.0 steps).

@lazka lazka merged commit a0364c9 into quodlibet:master Nov 30, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment