New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated German translation #2188

Merged
merged 3 commits into from Jan 11, 2017

Conversation

Projects
None yet
2 participants
@Mellthas
Contributor

Mellthas commented Jan 9, 2017

Updated German translation which was quite a bit out of date. Also, all the plugins are now translated. I left three unclear strings untranslated for now. I’ll file a separate issue on that.

Up for debate: I changed the translation of "pattern" to "Muster" instead of "Vorlage" in general because that seemed more appropriate to me and the expression was used many times more compared to the time the translation was last updated. Other than that, I tried to stay consistent with the existing translation.

@lazka

This comment has been minimized.

Member

lazka commented Jan 10, 2017

Thanks. Some tests fail, but they fail to state the exact reason, pushed a fix for that.

Here is the output for now:

E   AssertionError: One or more messages did not pass (ending punctuation missing).
E   "Couldn't find the 'Kanji Kana Simple Inverter' (kakasi)." - "»Kanji Kana Simple Inverter« (kakasi) wurde nicht gefunden" (de.po:1373, ../quodlibet/ext/editing/kakasi.py:63)
E   "Library directory the server connects to." - "Bibliotheksverzeichnis, mit dem sich der Server verbindet" (de.po:2884, ../quodlibet/ext/_shared/squeezebox/base.py:130)
E   "Reload all songs in your library. This can take a long time." - "Alle Titel in der Bibliothek neu laden (dauert möglicherweise lange)" (de.po:5301, ../quodlibet/qltk/prefs.py:660)
E   "_Customize Headers…" - "Listenspalten _anpassen ..." (de.po:5726, ../quodlibet/qltk/songlist.py:1112)

Up for debate: I changed the translation of "pattern" to "Muster" instead of "Vorlage" in general because that seemed more appropriate to me and the expression was used many times more compared to the time the translation was last updated. Other than that, I tried to stay consistent with the existing translation.

Sounds good to me, thanks.

Should we try to address the issues you raised first or merge this once tests pass?

@Mellthas

This comment has been minimized.

Contributor

Mellthas commented Jan 10, 2017

Fixed the punctuation errors. Can I run these tests locally? Because using ./setup.py test --to-run PO.de (as recommended in the translation how-to) I get no errors.

I think the issues with the unclear strings are minor and can be addressed later.

@lazka

This comment has been minimized.

Member

lazka commented Jan 11, 2017

These tests optionally depend on polib, called "python-polib" or "python2-polib" in most distros. I guess we should depend on it.

@lazka lazka merged commit e248a00 into quodlibet:quodlibet-3.8 Jan 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

lazka added a commit that referenced this pull request Jan 11, 2017

@Mellthas Mellthas deleted the Mellthas:quodlibet-3.8 branch Jan 11, 2017

@Mellthas Mellthas restored the Mellthas:quodlibet-3.8 branch Jan 11, 2017

@Mellthas Mellthas deleted the Mellthas:quodlibet-3.8 branch Jan 11, 2017

@Mellthas Mellthas restored the Mellthas:quodlibet-3.8 branch Jan 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment